Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Timeline expression initialization is still using "es" as function name #1631

Closed
zhongnansu opened this issue May 27, 2022 · 2 comments · Fixed by #2720
Closed

[BUG] Timeline expression initialization is still using "es" as function name #1631

zhongnansu opened this issue May 27, 2022 · 2 comments · Fixed by #2720
Assignees
Labels
bug Something isn't working roadmap timeline v2.7.0 visualizations Issues and PRs related to visualizations

Comments

@zhongnansu
Copy link
Member

zhongnansu commented May 27, 2022

Describe the bug

Timeline expression in "Timelion" visualization type is still using "es" as function name.
image

To Reproduce

Expected behavior
it should be rebranded as ".opensearch(*)"?

OpenSearch Version
1.2

Dashboards Version
1.2
Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@zhongnansu zhongnansu added bug Something isn't working untriaged visualizations Issues and PRs related to visualizations labels May 27, 2022
@kavilla
Copy link
Member

kavilla commented May 27, 2022

Hello @zhongnansu,

Thanks for opening. .es is available and .opensearch is available. We allow for both to ensure backwards compatibility to ensure users do not have to update their saved objects for the visualizations to work. Since this falls into the functionality realm we were given the okay to allow for both.

Would the bug be the initial creation of the visualization should be .opensearch?

@kavilla kavilla removed the untriaged label May 27, 2022
@zhongnansu zhongnansu changed the title [BUG] Timeline expression in "Timelion" visualization type is still using "es" as function name [BUG] Timeline expression initialization is still using "es" as function name May 27, 2022
@zhongnansu
Copy link
Member Author

Hello @zhongnansu,

Thanks for opening. .es is available and .opensearch is available. We allow for both to ensure backwards compatibility to ensure users do not have to update their saved objects for the visualizations to work. Since this falls into the functionality realm we were given the okay to allow for both.

Would the bug be the initial creation of the visualization should be .opensearch?

@kavilla Hi Rocky. You are right, I just tested it, .opensearch() does work. I updated the issue name, so it makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working roadmap timeline v2.7.0 visualizations Issues and PRs related to visualizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants