Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Close button appears outside the chrome of the sidebar #1443

Closed
peternied opened this issue Apr 11, 2022 · 3 comments
Closed

[BUG] Close button appears outside the chrome of the sidebar #1443

peternied opened this issue Apr 11, 2022 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists v2.0.0

Comments

@peternied
Copy link
Member

Describe the bug
On the collapsibleNav in OpenSearch Dashboards, there is a close button, and the button is floating outside the bounds of the nav. It seems like there is plenty of space to include the button in the nav itself.

To Reproduce
Steps to reproduce the behavior:

  1. Start opensearch-dashboards
  2. Sign in
  3. Look at the side nav menu
    image

Expected behavior
The button should be within the bounds of the nav bar

OpenSearch Version

Dashboards Version
v2.0.0, commit :db7cb6d115e

Host/Environment:

  • OS: Windows
  • Browser and version: Chrome v100
@kgcreative
Copy link
Member

This is intended behavior that is part of folding the latest EUI in. We will revise this in a future update. In the meantime, we should align on using the menuLeft and menuRight icons to open/close the side menu to better align with the correct behavior. For now, the button being outside the container is not unintended behavior.

Screen Shot 2022-04-11 at 1 30 41 PMScreen Shot 2022-04-11 at 1 30 57 PM

@kavilla
Copy link
Member

kavilla commented Apr 11, 2022

+1 @kgcreative

Yeah I agree! This is expected functionality form EUI. Based on this comment: #1370 (comment) should close this as duplicate for: #569

@seanneumann
Copy link
Contributor

@kavilla please do. Thanks.

@kavilla kavilla added duplicate This issue or pull request already exists and removed untriaged labels Apr 11, 2022
@kavilla kavilla closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists v2.0.0
Projects
None yet
Development

No branches or pull requests

4 participants