From bf9391902370377aeaca10ff3d10e74248c0abf8 Mon Sep 17 00:00:00 2001
From: Kristen Tian <tyarong@amazon.com>
Date: Thu, 6 Oct 2022 14:47:33 -0700
Subject: [PATCH] [MD]Update copy on index patten config DS step

Signed-off-by: Kristen Tian <tyarong@amazon.com>
---
 .../index_patterns/index_pattern.ts           |  3 +-
 .../header/__snapshots__/header.test.tsx.snap | 64 +++----------------
 .../components/header/header.scss             |  3 -
 .../components/header/header.test.tsx         |  1 -
 .../components/header/header.tsx              | 33 +++-------
 5 files changed, 21 insertions(+), 83 deletions(-)
 delete mode 100644 src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.scss

diff --git a/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts b/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts
index 7a966d2849c9..5e4d80df6ccd 100644
--- a/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts
+++ b/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts
@@ -370,7 +370,8 @@ export class IndexPattern implements IIndexPattern {
     return this.dataSourceRef
       ? [
           {
-            ...this.dataSourceRef,
+            id: this.dataSourceRef.id,
+            type: this.dataSourceRef.type,
             name: DATA_SOURCE_REFERNECE_NAME,
           },
         ]
diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap
index ded0546ce491..8a79ee810f18 100644
--- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap
+++ b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap
@@ -21,7 +21,7 @@ exports[`Header should render existing data sources list when choose to use data
     </EuiTitle>
     <EuiText>
       <FormattedMessage
-        defaultMessage="Please pick the data source -- within which to configure index patterns."
+        defaultMessage="Pick a data source within which to configure index patterns."
         id="indexPatternManagement.createIndexPattern.stepDataSourceLabel"
         values={Object {}}
       />
@@ -36,25 +36,15 @@ exports[`Header should render existing data sources list when choose to use data
       id="useDefault"
       label={
         <FormattedMessage
-          defaultMessage="Use default"
+          defaultMessage="Use default data source"
           id="indexPatternManagement.createIndexPattern.stepDataSource.useDefaultLabel"
           values={Object {}}
         />
       }
       onChange={[Function]}
     />
-    <EuiText
-      className="dataSourceRadioHelperText"
-      size="s"
-    >
-      <FormattedMessage
-        defaultMessage="Uses the default data source configured by the OpenSearch Dashboards administrator."
-        id="indexPatternManagement.createIndexPattern.stepDataSource.useDefault.helperText"
-        values={Object {}}
-      />
-    </EuiText>
     <EuiSpacer
-      size="l"
+      size="m"
     />
     <EuiRadio
       checked={true}
@@ -63,23 +53,13 @@ exports[`Header should render existing data sources list when choose to use data
       id="useDataSource"
       label={
         <FormattedMessage
-          defaultMessage="Choose data source"
+          defaultMessage="User external data source connection"
           id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSourceLabel"
           values={Object {}}
         />
       }
       onChange={[Function]}
     />
-    <EuiText
-      className="dataSourceRadioHelperText"
-      size="s"
-    >
-      <FormattedMessage
-        defaultMessage="Connect to an existing external data source."
-        id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSource.helperText"
-        values={Object {}}
-      />
-    </EuiText>
     <EuiFlexItem
       grow={false}
     >
@@ -87,13 +67,7 @@ exports[`Header should render existing data sources list when choose to use data
         size="m"
       />
       <EuiSelectable
-        aria-label={
-          <FormattedMessage
-            defaultMessage="Search data sources"
-            id="indexPatternManagement.createIndexPattern.stepDataSource.searchLabel"
-            values={Object {}}
-          />
-        }
+        aria-label="Search data sources"
         isPreFiltered={false}
         onChange={[Function]}
         options={Array []}
@@ -160,7 +134,7 @@ exports[`Header should render normally 1`] = `
     </EuiTitle>
     <EuiText>
       <FormattedMessage
-        defaultMessage="Please pick the data source -- within which to configure index patterns."
+        defaultMessage="Pick a data source within which to configure index patterns."
         id="indexPatternManagement.createIndexPattern.stepDataSourceLabel"
         values={Object {}}
       />
@@ -175,25 +149,15 @@ exports[`Header should render normally 1`] = `
       id="useDefault"
       label={
         <FormattedMessage
-          defaultMessage="Use default"
+          defaultMessage="Use default data source"
           id="indexPatternManagement.createIndexPattern.stepDataSource.useDefaultLabel"
           values={Object {}}
         />
       }
       onChange={[Function]}
     />
-    <EuiText
-      className="dataSourceRadioHelperText"
-      size="s"
-    >
-      <FormattedMessage
-        defaultMessage="Uses the default data source configured by the OpenSearch Dashboards administrator."
-        id="indexPatternManagement.createIndexPattern.stepDataSource.useDefault.helperText"
-        values={Object {}}
-      />
-    </EuiText>
     <EuiSpacer
-      size="l"
+      size="m"
     />
     <EuiRadio
       checked={false}
@@ -202,23 +166,13 @@ exports[`Header should render normally 1`] = `
       id="useDataSource"
       label={
         <FormattedMessage
-          defaultMessage="Choose data source"
+          defaultMessage="User external data source connection"
           id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSourceLabel"
           values={Object {}}
         />
       }
       onChange={[Function]}
     />
-    <EuiText
-      className="dataSourceRadioHelperText"
-      size="s"
-    >
-      <FormattedMessage
-        defaultMessage="Connect to an existing external data source."
-        id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSource.helperText"
-        values={Object {}}
-      />
-    </EuiText>
     <EuiSpacer
       size="m"
     />
diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.scss b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.scss
deleted file mode 100644
index 048ae2981c05..000000000000
--- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.scss
+++ /dev/null
@@ -1,3 +0,0 @@
-.dataSourceRadioHelperText {
-  text-indent: 24px;
-}
diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx
index dc8b72341b80..8a7aa9b1e461 100644
--- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx
+++ b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx
@@ -5,7 +5,6 @@
 
 import React from 'react';
 import { Header } from '../header';
-import { shallow } from 'enzyme';
 import { shallowWithIntl } from 'test_utils/enzyme_helpers';
 
 jest.mock('../../../../../../../../../plugins/opensearch_dashboards_react/public', () => ({
diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx
index 75f641b70164..71df5637f1ba 100644
--- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx
+++ b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx
@@ -4,7 +4,6 @@
  */
 
 import React, { Fragment, useState } from 'react';
-import './header.scss';
 
 import {
   EuiButton,
@@ -111,7 +110,7 @@ export const Header: React.FC<HeaderProps> = (props: HeaderProps) => {
         <EuiText>
           <FormattedMessage
             id="indexPatternManagement.createIndexPattern.stepDataSourceLabel"
-            defaultMessage="Please pick the data source -- within which to configure index patterns."
+            defaultMessage="Pick a data source within which to configure index patterns."
           />
         </EuiText>
         <EuiSpacer size="m" />
@@ -121,49 +120,37 @@ export const Header: React.FC<HeaderProps> = (props: HeaderProps) => {
           label={
             <FormattedMessage
               id="indexPatternManagement.createIndexPattern.stepDataSource.useDefaultLabel"
-              defaultMessage="Use default"
+              defaultMessage="Use default data source"
             />
           }
           checked={defaultChecked}
           onChange={(e) => onChangeDefaultChecked(e)}
           compressed
         />
-        <EuiText size="s" className="dataSourceRadioHelperText">
-          <FormattedMessage
-            id="indexPatternManagement.createIndexPattern.stepDataSource.useDefault.helperText"
-            defaultMessage="Uses the default data source configured by the OpenSearch Dashboards administrator."
-          />
-        </EuiText>
-        <EuiSpacer size="l" />
+        <EuiSpacer size="m" />
         <EuiRadio
           data-test-subj="createIndexPatternStepDataSourceUseDataSourceRadio"
           id={'useDataSource'}
           label={
             <FormattedMessage
               id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSourceLabel"
-              defaultMessage="Choose data source"
+              defaultMessage="User external data source connection"
             />
           }
           checked={dataSourceChecked}
           onChange={(e) => onChangeDataSourceChecked(e)}
           compressed
         />
-        <EuiText size="s" className="dataSourceRadioHelperText">
-          <FormattedMessage
-            id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSource.helperText"
-            defaultMessage="Connect to an existing external data source."
-          />
-        </EuiText>
         {dataSourceChecked && (
           <EuiFlexItem grow={false}>
             <EuiSpacer size="m" />
             <EuiSelectable
-              aria-label={
-                <FormattedMessage
-                  id="indexPatternManagement.createIndexPattern.stepDataSource.searchLabel"
-                  defaultMessage="Search data sources"
-                />
-              }
+              aria-label={i18n.translate(
+                'indexPatternManagement.createIndexPattern.stepDataSource.searchlabel',
+                {
+                  defaultMessage: 'Search data sources',
+                }
+              )}
               searchable
               searchProps={{
                 'data-test-subj': 'selectDataSources',