From bd62d85b71d6cd9809a71f3361742bc6bacffbca Mon Sep 17 00:00:00 2001 From: sayuree <52072402+sayuree@users.noreply.github.com> Date: Tue, 18 Apr 2023 05:11:43 +0600 Subject: [PATCH] Add tooltip to help icon (#3626) * Add tooltip to help icon Signed-off-by: sabina.zaripova Add tooltip to menu icon Signed-off-by: sabina.zaripova --- CHANGELOG.md | 1 + .../header/__snapshots__/header.test.tsx.snap | 4946 ++++++++++++++++- .../header_help_menu.test.tsx.snap | 4422 +++++++++++++++ src/core/public/chrome/ui/header/header.tsx | 8 +- .../chrome/ui/header/header_help_menu.tsx | 10 +- 5 files changed, 9380 insertions(+), 7 deletions(-) create mode 100644 src/core/public/chrome/ui/header/__snapshots__/header_help_menu.test.tsx.snap diff --git a/CHANGELOG.md b/CHANGELOG.md index 602ce0e26cae..3b12b37df6c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -141,6 +141,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842)) - [Build] Fixed "Last Access Time" not being set by `scanCopy` on Windows ([#2964](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2964)) - Update `leaflet-vega` and fix its usage ([#3005](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3005)) +- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573)) ### 🚞 Infrastructure diff --git a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap index 5ad89191b0c9..cf569b0bec3f 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap @@ -2409,6 +2409,157 @@ exports[`Header renders 1`] = ` "syncErrorThrown": false, "syncErrorValue": null, }, + "isStopped": false, + "syncErrorThrowable": true, + "syncErrorThrown": false, + "syncErrorValue": null, + }, + ], + "thrownError": null, + } + } + /> + + + + + + + +
+ +
+ +
+ + + + + + + + + + , + } + } + className="euiHeaderSectionItemButton" + color="text" + data-test-subj="toggleNavButton" + onClick={[Function]} + > + + + +
+
+ +
+ + } closePopover={[Function]} @@ -4730,6 +4886,39 @@ exports[`Header renders 1`] = ` aria-expanded={false} aria-haspopup="true" aria-label="Help menu" + buttonRef={ + Object { + "current": , + } + } + className="euiHeaderSectionItemButton" + color="text" onClick={[Function]} >
@@ -6139,3 +6356,4722 @@ exports[`Header renders 1`] = ` `; + +exports[`Header renders condensed header 1`] = ` +
+
+
+ +
+ +
+ +
+ + + + + + + + + + , + } + } + className="euiHeaderSectionItemButton" + color="text" + data-test-subj="toggleNavButton" + onClick={[Function]} + > + + + +
+
+ +
+ +
+
+ +
+ + + + + + +
+ +
+
+
+
+
+
+ , + } + } + className="euiHeaderSectionItemButton header__homeLoaderNavButton" + color="text" + data-test-subj="homeLoader" + href="/" + onClick={[Function]} + title="Go to home page" + > + + + + + +
+ + + + + +
+
+ + + + + +
+
+
+
+
+
+
+
+
+
+
+
+
+ + + + + + + + +
+ +
+
+ +
+ +
+ +
+ +
+ + +
+ +
+
+ +
+ +
+
+ +
+ + + + + + + } + closePopover={[Function]} + data-test-subj="helpMenuButton" + display="inlineBlock" + hasArrow={true} + id="headerHelpMenu" + isOpen={false} + ownFocus={true} + panelPaddingSize="m" + repositionOnScroll={true} + > +
+
+ + + + + + + + + + + , + } + } + className="euiHeaderSectionItemButton" + color="text" + onClick={[Function]} + > + + + +
+
+
+
+
+
+
+
+ +
+ +
+ + + +
+
+`; diff --git a/src/core/public/chrome/ui/header/__snapshots__/header_help_menu.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/header_help_menu.test.tsx.snap new file mode 100644 index 000000000000..5406fbf6abaa --- /dev/null +++ b/src/core/public/chrome/ui/header/__snapshots__/header_help_menu.test.tsx.snap @@ -0,0 +1,4422 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Header help menu hides survey link 1`] = ` + + + + + + + } + closePopover={[Function]} + data-test-subj="helpMenuButton" + display="inlineBlock" + hasArrow={true} + id="headerHelpMenu" + isOpen={true} + ownFocus={true} + panelPaddingSize="m" + repositionOnScroll={true} + > +
+
+ + + + + + + + + + + , + } + } + className="euiHeaderSectionItemButton" + color="text" + onClick={[Function]} + > + + + +
+ + +
+