diff --git a/src/cli_plugin/install/__fixtures__/replies/invalid_name.zip b/src/cli_plugin/install/__fixtures__/replies/invalid_name.zip index 4d77ba0d389a..cd24e700b918 100644 Binary files a/src/cli_plugin/install/__fixtures__/replies/invalid_name.zip and b/src/cli_plugin/install/__fixtures__/replies/invalid_name.zip differ diff --git a/src/cli_plugin/install/__fixtures__/replies/test_plugin.zip b/src/cli_plugin/install/__fixtures__/replies/test_plugin.zip index 57f7455de10f..7997125e11ee 100644 Binary files a/src/cli_plugin/install/__fixtures__/replies/test_plugin.zip and b/src/cli_plugin/install/__fixtures__/replies/test_plugin.zip differ diff --git a/src/cli_plugin/install/__fixtures__/replies/test_plugin_different_version.zip b/src/cli_plugin/install/__fixtures__/replies/test_plugin_different_version.zip index b84473cebf95..030c4b9a90b9 100644 Binary files a/src/cli_plugin/install/__fixtures__/replies/test_plugin_different_version.zip and b/src/cli_plugin/install/__fixtures__/replies/test_plugin_different_version.zip differ diff --git a/src/cli_plugin/install/__fixtures__/replies/test_plugin_many.zip b/src/cli_plugin/install/__fixtures__/replies/test_plugin_many.zip index bc58c2bdb9dd..3e0d0bc625cc 100644 Binary files a/src/cli_plugin/install/__fixtures__/replies/test_plugin_many.zip and b/src/cli_plugin/install/__fixtures__/replies/test_plugin_many.zip differ diff --git a/src/cli_plugin/install/__fixtures__/replies/test_plugin_no_opensearch_dashboards.zip b/src/cli_plugin/install/__fixtures__/replies/test_plugin_no_opensearch_dashboards.zip index d460c65978c6..c7f9d816c5c9 100644 Binary files a/src/cli_plugin/install/__fixtures__/replies/test_plugin_no_opensearch_dashboards.zip and b/src/cli_plugin/install/__fixtures__/replies/test_plugin_no_opensearch_dashboards.zip differ diff --git a/src/cli_plugin/install/pack.test.js b/src/cli_plugin/install/pack.test.js index e2877e6735e5..37d2c51f0b21 100644 --- a/src/cli_plugin/install/pack.test.js +++ b/src/cli_plugin/install/pack.test.js @@ -88,11 +88,11 @@ describe('opensearchDashboards cli', function () { "bin", "bin/executable", "bin/not-executable", - "opensearch_dashboards.json", "node_modules", "node_modules/some-package", "node_modules/some-package/index.js", "node_modules/some-package/package.json", + "opensearch_dashboards.json", "public", "public/index.js", ] @@ -170,7 +170,7 @@ describe('opensearchDashboards cli', function () { it('throw an error if there an invalid plugin name', async () => { await copyReplyFile('invalid_name.zip'); await expect(getPackData(settings, logger)).rejects.toThrowErrorMatchingInlineSnapshot( - `"No opensearch-dashboards plugins found in archive"` + `"Invalid plugin name [invalid name] in opensearch_dashboards.json, expected it to be valid camelCase"` ); }); }); diff --git a/src/cli_plugin/install/zip.test.js b/src/cli_plugin/install/zip.test.js index 13b543681262..fa144fe6b60b 100644 --- a/src/cli_plugin/install/zip.test.js +++ b/src/cli_plugin/install/zip.test.js @@ -47,7 +47,15 @@ describe('opensearchDashboards cli', function () { describe('analyzeArchive', function () { it('returns array of plugins', async () => { const packages = await analyzeArchive(archivePath); - expect(packages).toMatchInlineSnapshot(`Array []`); + expect(packages).toMatchInlineSnapshot(` + Array [ + Object { + "id": "testPlugin", + "opensearchDashboardsVersion": "1.0.0", + "stripPrefix": "opensearch-dashboards/test-plugin", + }, + ] + `); }); }); @@ -56,7 +64,20 @@ describe('opensearchDashboards cli', function () { const archive = path.resolve(repliesPath, 'test_plugin.zip'); await extractArchive(archive, tempPath, 'opensearch-dashboards/test-plugin'); - expect(glob.sync('**/*', { cwd: tempPath })).toMatchInlineSnapshot(`Array []`); + expect(glob.sync('**/*', { cwd: tempPath })).toMatchInlineSnapshot(` + Array [ + "bin", + "bin/executable", + "bin/not-executable", + "node_modules", + "node_modules/some-package", + "node_modules/some-package/index.js", + "node_modules/some-package/package.json", + "opensearch_dashboards.json", + "public", + "public/index.js", + ] + `); }); });