From 875be0ad672ec0e72ebb778eceff44442df55533 Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Thu, 9 Mar 2023 09:22:40 -0800 Subject: [PATCH] Simplifies `re2` upgrade instructions (#3328) (#3561) (#3567) * Follow-up from #3018 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> (cherry picked from commit 844059ca8d773030908c16527b39bbb38509e421) Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> (cherry picked from commit 3107769f378b87692041b29ccccd67a35bf91ce0) Signed-off-by: github-actions[bot] # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] --- src/dev/build/tasks/patch_native_modules_task.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/dev/build/tasks/patch_native_modules_task.ts b/src/dev/build/tasks/patch_native_modules_task.ts index 3ed94038caf1..65dbd40f58f0 100644 --- a/src/dev/build/tasks/patch_native_modules_task.ts +++ b/src/dev/build/tasks/patch_native_modules_task.ts @@ -49,6 +49,16 @@ interface Package { >; } +/* Process for updating URLs and checksums after bumping the version of `re2` or NodeJS: + * 1. Match the `version` with the version in the yarn.lock file. + * 2. Match the module version, the digits at the end of the filename, with the output of + * `node -p process.versions.modules`. + * 3. Confirm that the URLs exist for each platform-architecture combo on + * https://github.com/uhop/node-re2/releases/tag/[VERSION]; reach out to maintainers for ARM + * releases of `re2` as they currently don't have an official ARM release. + * 4. Generate new checksums for each artifact by downloading each one and calling + * `shasum -a 256` or `sha256sum` on the downloaded file. + */ const packages: Package[] = [ { name: 're2',