From 4fcc7bb3b5633227715e3310b6a2c67712e34c42 Mon Sep 17 00:00:00 2001 From: Kawika Avilla Date: Fri, 26 Mar 2021 19:05:13 +0000 Subject: [PATCH] [Tests] update TODOs with [RENAMEME] and ref to .com PR comment to include RENAMEME for easy grepping and update a ref to opensearch.com to opensearch.co so that it is easier to grep while renaming. Then had to regenerate the snapshots. Signed-off-by: Kawika Avilla --- packages/osd-apm-config-loader/src/config.ts | 2 +- src/core/public/doc_links/doc_links_service.test.ts | 2 +- src/core/public/doc_links/doc_links_service.ts | 3 +-- .../empty_state/__snapshots__/empty_state.test.tsx.snap | 2 +- .../public/markdown/markdown.test.tsx | 2 +- .../insecure_cluster_service/components/default_alert.test.tsx | 2 +- src/plugins/share/public/opensearch_dashboards_url.ts | 1 - 7 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/osd-apm-config-loader/src/config.ts b/packages/osd-apm-config-loader/src/config.ts index eee2f10a27d2..74cacea11ccd 100644 --- a/packages/osd-apm-config-loader/src/config.ts +++ b/packages/osd-apm-config-loader/src/config.ts @@ -42,7 +42,7 @@ const getDefaultConfig = (isDistributable: boolean): ApmAgentConfig => { return { active: false, serverUrl: 'https://f1542b814f674090afd914960583265f.apm.us-central1.gcp.cloud.es.io:443', - // TODO: serverUrl + // TODO: [RENAMEME] Update serverUrl and secretToken if we have replacements // The secretToken below is intended to be hardcoded in this file even though // it makes it public. This is not a security/privacy issue. Normally we'd // instead disable the need for a secretToken in the APM Server config where diff --git a/src/core/public/doc_links/doc_links_service.test.ts b/src/core/public/doc_links/doc_links_service.test.ts index 1a5ad5df727c..f14b03be2076 100644 --- a/src/core/public/doc_links/doc_links_service.test.ts +++ b/src/core/public/doc_links/doc_links_service.test.ts @@ -28,7 +28,7 @@ describe('DocLinksService#start()', () => { const api = service.start({ injectedMetadata }); expect(api.DOC_LINK_VERSION).toEqual('test-branch'); expect(api.links.opensearchDashboards).toEqual( - 'https://www.opensearch.com/guide/en/kibana/test-branch/index.html' + 'https://www.opensearch.co/guide/en/kibana/test-branch/index.html' ); }); }); diff --git a/src/core/public/doc_links/doc_links_service.ts b/src/core/public/doc_links/doc_links_service.ts index b06fe69f3daf..25ca722a4c54 100644 --- a/src/core/public/doc_links/doc_links_service.ts +++ b/src/core/public/doc_links/doc_links_service.ts @@ -29,8 +29,7 @@ export class DocLinksService { public setup() {} public start({ injectedMetadata }: StartDeps): DocLinksStart { const DOC_LINK_VERSION = injectedMetadata.getOpenSearchDashboardsBranch(); - // const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.co/'; - const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.com/'; + const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.co/'; const OPENSEARCH_DOCS = `${OPENSEARCH_WEBSITE_URL}guide/en/elasticsearch/reference/${DOC_LINK_VERSION}/`; return deepFreeze({ diff --git a/src/plugins/index_pattern_management/public/components/index_pattern_table/empty_state/__snapshots__/empty_state.test.tsx.snap b/src/plugins/index_pattern_management/public/components/index_pattern_table/empty_state/__snapshots__/empty_state.test.tsx.snap index 9a6f1087c115..ba61d61ebc0d 100644 --- a/src/plugins/index_pattern_management/public/components/index_pattern_table/empty_state/__snapshots__/empty_state.test.tsx.snap +++ b/src/plugins/index_pattern_management/public/components/index_pattern_table/empty_state/__snapshots__/empty_state.test.tsx.snap @@ -132,7 +132,7 @@ exports[`EmptyState should render normally 1`] = ` Object { "description": { const component = shallow( diff --git a/src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx b/src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx index 02d7f07c0252..4ccba8f1fb9a 100644 --- a/src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx +++ b/src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx @@ -19,7 +19,7 @@ import { defaultAlertText } from './default_alert'; -// TODO: Ignoring because the defaultAlertText was commented out because it upsells a hosted solution. +// TODO: [RENAMEME] Ignoring because the defaultAlertText was commented out because it upsells a hosted solution. xdescribe('defaultAlertText', () => { it('creates a valid MountPoint that can cleanup correctly', () => { const mountPoint = defaultAlertText(jest.fn()); diff --git a/src/plugins/share/public/opensearch_dashboards_url.ts b/src/plugins/share/public/opensearch_dashboards_url.ts index bd75ef9de609..c4a8ae64b4cf 100644 --- a/src/plugins/share/public/opensearch_dashboards_url.ts +++ b/src/plugins/share/public/opensearch_dashboards_url.ts @@ -17,7 +17,6 @@ * under the License. */ -// TODO: Replace this logic with OpenSearchDashboardsURL once it is available. // https://github.com/elastic/kibana/issues/64497 export class OpenSearchDashboardsURL { public readonly path: string;