diff --git a/CHANGELOG.md b/CHANGELOG.md
index 017d697c4eac..c7e8507a964b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* [Multi DataSource] Make text content dynamically translated & update unit tests ([#2570](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2570))
* [Vis Builder] Change classname prefix wiz to vb ([#2581](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2581/files))
* [Vis Builder] Change wizard to vis_builder in file names and paths ([#2587](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2587))
+* [Multi DataSource] Address UX comments on Data source list and create page ([#2625](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2625))
+* [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635))
### 🐛 Bug Fixes
* [Vis Builder] Fixes auto bounds for timeseries bar chart visualization ([2401](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2401))
@@ -32,6 +34,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* [Vis Builder] Update vislib params and misc fixes ([2610](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2610))
* [MD] Add data source param to low-level search call in Discover ([#2431](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2431))
* [Multi DataSource] Skip data source view in index pattern step when pick default ([#2574](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2574))
+* [Multi DataSource] Address UX comments on Edit Data source page ([#2629](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2629))
### 🚞 Infrastructure
diff --git a/src/plugins/data_source_management/public/components/create_button/create_button.test.tsx b/src/plugins/data_source_management/public/components/create_button/create_button.test.tsx
index 64906045b004..f54aef129df3 100644
--- a/src/plugins/data_source_management/public/components/create_button/create_button.test.tsx
+++ b/src/plugins/data_source_management/public/components/create_button/create_button.test.tsx
@@ -13,10 +13,11 @@ const createButtonIdentifier = `[data-test-subj="createDataSourceButton"]`;
describe('CreateButton', () => {
const history = (scopedHistoryMock.create() as unknown) as ScopedHistory;
+ const dataTestSubj = 'createDataSourceButton';
let component: ShallowWrapper, React.Component<{}, {}, any>>;
beforeEach(() => {
- component = shallow();
+ component = shallow();
});
it('should render normally', () => {
diff --git a/src/plugins/data_source_management/public/components/create_button/create_button.tsx b/src/plugins/data_source_management/public/components/create_button/create_button.tsx
index 072eb8af6029..7c893af0209d 100644
--- a/src/plugins/data_source_management/public/components/create_button/create_button.tsx
+++ b/src/plugins/data_source_management/public/components/create_button/create_button.tsx
@@ -11,13 +11,15 @@ import { FormattedMessage } from '@osd/i18n/react';
interface Props {
history: History;
+ isEmptyState?: boolean;
+ dataTestSubj: string;
}
-export const CreateButton = ({ history }: Props) => {
+export const CreateButton = ({ history, isEmptyState, dataTestSubj }: Props) => {
return (
history.push('/create')}
>
+
+
+
@@ -401,7 +408,7 @@ exports[`Datasource Management: Create Datasource Wizard case1: should load reso
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value=""
>
@@ -1079,6 +1086,13 @@ exports[`Datasource Management: Create Datasource Wizard case2: should fail to l
+
+
+
@@ -1368,7 +1382,7 @@ exports[`Datasource Management: Create Datasource Wizard case2: should fail to l
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value=""
>
diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
index 1006968b632f..fcd197cc0827 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/__snapshots__/create_data_source_form.test.tsx.snap
@@ -140,6 +140,13 @@ exports[`Datasource Management: Create Datasource form should create data source
+
+
+
@@ -429,7 +436,7 @@ exports[`Datasource Management: Create Datasource form should create data source
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value="https://test.com"
>
@@ -867,6 +874,13 @@ exports[`Datasource Management: Create Datasource form should create data source
+
+
+
@@ -1156,7 +1170,7 @@ exports[`Datasource Management: Create Datasource form should create data source
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value="https://test.com"
>
@@ -1792,6 +1806,13 @@ exports[`Datasource Management: Create Datasource form should render normally 1`
+
+
+
@@ -2081,7 +2102,7 @@ exports[`Datasource Management: Create Datasource form should render normally 1`
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value=""
>
@@ -2717,6 +2738,13 @@ exports[`Datasource Management: Create Datasource form should throw validation e
+
+
+
@@ -3023,7 +3051,7 @@ exports[`Datasource Management: Create Datasource form should throw validation e
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
- placeholder="Sample URL: https://connectionurl.com"
+ placeholder="https://connectionurl.com"
value="https://test.com"
>
diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
index e5d779296a58..429790231a5c 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
@@ -287,6 +287,7 @@ export class CreateDataSourceForm extends React.Component<
return (
{this.renderHeader()}
+
{/* Endpoint section */}
{this.renderSectionHeader(
@@ -354,7 +355,7 @@ export class CreateDataSourceForm extends React.Component<
placeholder={i18n.translate(
'dataSourcesManagement.createDataSource.endpointPlaceholder',
{
- defaultMessage: 'Sample URL: https://connectionurl.com',
+ defaultMessage: 'https://connectionurl.com',
}
)}
isInvalid={!!this.state.formErrorsByField.endpoint.length}
diff --git a/src/plugins/data_source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx b/src/plugins/data_source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx
index aaa50435d5e3..08ac198c7561 100644
--- a/src/plugins/data_source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx
+++ b/src/plugins/data_source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx
@@ -75,7 +75,7 @@ export const CreateDataSourceWizard: React.FunctionComponent {
- toasts.addWarning(i18n.translate(id, { defaultMessage }));
+ toasts.addDanger(i18n.translate(id, { defaultMessage }));
};
/* Render the creation wizard */
diff --git a/src/plugins/data_source_management/public/components/data_source_table/__snapshots__/data_source_table.test.tsx.snap b/src/plugins/data_source_management/public/components/data_source_table/__snapshots__/data_source_table.test.tsx.snap
index abd6fc95c88d..53e2fac37130 100644
--- a/src/plugins/data_source_management/public/components/data_source_table/__snapshots__/data_source_table.test.tsx.snap
+++ b/src/plugins/data_source_management/public/components/data_source_table/__snapshots__/data_source_table.test.tsx.snap
@@ -108,6 +108,7 @@ exports[`DataSourceTable should get datasources failed should render empty table
className="euiFlexItem euiFlexItem--flexGrowZero"
>
- }
- title={
-
-
-
- }
+
-
-
-
-
-
-
-
-
- Endpoint
-
-
-
-
-
-
-
-
-
-
-
- This connection information is used for reference in tables and when adding to a data source connection
-
-
-
-
-
-
-
-
-
-
+ Endpoint URL
+
+
+
+
+
+
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
-
-
-
+
+
+
-
+
-
-
-
- }
- title={
-
-
-
- }
+
-
-
-
-
-
-
-
-
- Endpoint
-
-
-
-
-
-
-
-
-
-
-
- This connection information is used for reference in tables and when adding to a data source connection
-
-
-
-
-
-
-
-
-
-
+ Endpoint URL
+
+
+
+
+
+
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
-
-
-
+
+
+
-
+
{
existingDatasourceNamesList={existingDatasourceNamesList}
onDeleteDataSource={mockFn}
handleSubmit={mockFn}
+ displayToastMessage={mockFn}
/>
),
{
@@ -229,6 +230,7 @@ describe('Datasource Management: Edit Datasource Form', () => {
existingDatasourceNamesList={existingDatasourceNamesList}
onDeleteDataSource={mockFn}
handleSubmit={mockFn}
+ displayToastMessage={mockFn}
/>
),
{
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
index 00c205fa1ade..bda8709cf509 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
@@ -29,6 +29,7 @@ import {
credentialSourceOptions,
DataSourceAttributes,
DataSourceManagementContextValue,
+ ToastMessageItem,
UsernamePasswordTypedContent,
} from '../../../../types';
import { context as contextType } from '../../../../../../opensearch_dashboards_react/public';
@@ -45,6 +46,7 @@ export interface EditDataSourceProps {
existingDatasourceNamesList: string[];
handleSubmit: (formValues: DataSourceAttributes) => void;
onDeleteDataSource?: () => void;
+ displayToastMessage: (info: ToastMessageItem) => void;
}
export interface EditDataSourceState {
formErrorsByField: CreateEditDataSourceValidation;
@@ -57,6 +59,7 @@ export interface EditDataSourceState {
};
showUpdatePasswordModal: boolean;
showUpdateOptions: boolean;
+ isLoading: boolean;
}
export class EditDataSourceForm extends React.Component {
@@ -81,6 +84,7 @@ export class EditDataSourceForm extends React.Component {
+ onClickUpdateDataSource = async () => {
if (this.isFormValid()) {
// update data source endpoint is currently not supported/allowed
const formValues: DataSourceAttributes = {
@@ -225,7 +229,19 @@ export class EditDataSourceForm extends React.Component {
+ updatePassword = async (password: string) => {
const { title, description, auth } = this.props.existingDataSource;
const updateAttributes: DataSourceAttributes = {
title,
@@ -261,8 +277,21 @@ export class EditDataSourceForm extends React.Component
-
-
- {
-
- }
-
- }
- description={
-
- {
-
- }
-
- }
+ {/* Endpoint */}
+
- {/* Endpoint */}
-
-
-
-
+
+
);
};
@@ -653,6 +660,7 @@ export class EditDataSourceForm extends React.Component
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx
index 88e050394b89..8a73bcccc275 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx
@@ -80,6 +80,7 @@ export const Header = ({
confirmButtonText={i18n.translate('dataSourcesManagement.editDataSource.delete', {
defaultMessage: 'Delete',
})}
+ buttonColor="danger"
defaultFocusedButton="confirm"
data-test-subj="editDatasourceDeleteConfirmModal"
>
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.test.tsx b/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.test.tsx
index d8bd006f9dc1..d11f8c8bc9da 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.test.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.test.tsx
@@ -103,7 +103,7 @@ describe('Datasource Management: Edit Datasource Wizard', () => {
expect(history.push).toBeCalledWith('');
});
test('should fail to update datasource', async () => {
- spyOn(utils, 'updateDataSourceById').and.throwError('error');
+ spyOn(utils, 'updateDataSourceById').and.returnValue(new Error(''));
await act(async () => {
// @ts-ignore
await component.find(formIdentifier).first().prop('handleSubmit')(
diff --git a/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.tsx b/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.tsx
index 24e6448df35a..9bbaecfccce4 100644
--- a/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.tsx
+++ b/src/plugins/data_source_management/public/components/edit_data_source/edit_data_source.tsx
@@ -51,49 +51,48 @@ export const EditDataSource: React.FunctionComponent {
(async function () {
- setIsLoading(true);
- try {
- const fetchDataSourceById = await getDataSourceById(dataSourceID, savedObjects.client);
- const listOfDataSources: DataSourceTableItem[] = await getDataSources(savedObjects.client);
- if (fetchDataSourceById) {
- setDataSource(fetchDataSourceById);
- setBreadcrumbs(getEditBreadcrumbs(fetchDataSourceById));
- }
- if (Array.isArray(listOfDataSources) && listOfDataSources.length) {
- setExistingDatasourceNamesList(
- listOfDataSources.map((datasource) => datasource.title?.toLowerCase())
- );
- }
- } catch (e) {
- setDataSource(defaultDataSource);
- handleDisplayToastMessage({
- id: 'dataSourcesManagement.editDataSource.editDataSourceFailMsg',
- defaultMessage: 'Unable to find the Data Source.',
- });
- props.history.push('');
- } finally {
- setIsLoading(false);
- }
+ await fetchDataSourceDetailsByID();
})();
});
- /* Handle submit - create data source*/
- const handleSubmit = async (attributes: DataSourceAttributes) => {
+ const fetchDataSourceDetailsByID = async () => {
setIsLoading(true);
try {
- await updateDataSourceById(savedObjects.client, dataSourceID, attributes);
- props.history.push('');
+ const fetchDataSourceById = await getDataSourceById(dataSourceID, savedObjects.client);
+ const listOfDataSources: DataSourceTableItem[] = await getDataSources(savedObjects.client);
+ if (fetchDataSourceById) {
+ setDataSource(fetchDataSourceById);
+ setBreadcrumbs(getEditBreadcrumbs(fetchDataSourceById));
+ }
+ if (Array.isArray(listOfDataSources) && listOfDataSources.length) {
+ setExistingDatasourceNamesList(
+ listOfDataSources.map((datasource) => datasource.title?.toLowerCase())
+ );
+ }
} catch (e) {
- setIsLoading(false);
+ setDataSource(defaultDataSource);
handleDisplayToastMessage({
- id: 'dataSourcesManagement.editDataSource.editDataSourceFailMsg',
- defaultMessage: 'Updating the Data Source failed with some errors. Please try it again.',
+ id: 'dataSourcesManagement.editDataSource.fetchDataSourceFailMsg',
+ defaultMessage: 'Unable to find the Data Source.',
});
+ props.history.push('');
+ } finally {
+ setIsLoading(false);
}
};
- const handleDisplayToastMessage = ({ id, defaultMessage }: ToastMessageItem) => {
- toasts.addWarning(i18n.translate(id, { defaultMessage }));
+ /* Handle submit - create data source*/
+ const handleSubmit = async (attributes: DataSourceAttributes) => {
+ await updateDataSourceById(savedObjects.client, dataSourceID, attributes);
+ await fetchDataSourceDetailsByID();
+ };
+
+ const handleDisplayToastMessage = ({ id, defaultMessage, success }: ToastMessageItem) => {
+ if (success) {
+ toasts.addSuccess(i18n.translate(id, { defaultMessage }));
+ } else {
+ toasts.addWarning(i18n.translate(id, { defaultMessage }));
+ }
};
/* Handle delete - data source*/
@@ -124,6 +123,7 @@ export const EditDataSource: React.FunctionComponent
) : null}
{isLoading || !dataSource?.endpoint ? : null}
diff --git a/src/plugins/data_source_management/public/management_app/compoenent/experimental_callout/experimental_callout.tsx b/src/plugins/data_source_management/public/management_app/compoenent/experimental_callout/experimental_callout.tsx
index 611e410e373a..23f0d45a3206 100644
--- a/src/plugins/data_source_management/public/management_app/compoenent/experimental_callout/experimental_callout.tsx
+++ b/src/plugins/data_source_management/public/management_app/compoenent/experimental_callout/experimental_callout.tsx
@@ -23,7 +23,7 @@ export const ExperimentalCallout = ({ docLinks }: { docLinks: DocLinksStart }) =
{
}
@@ -44,7 +44,7 @@ export const ExperimentalCallout = ({ docLinks }: { docLinks: DocLinksStart }) =
{
}
diff --git a/src/plugins/data_source_management/public/types.ts b/src/plugins/data_source_management/public/types.ts
index a689cb4a593e..fe52466df1e5 100644
--- a/src/plugins/data_source_management/public/types.ts
+++ b/src/plugins/data_source_management/public/types.ts
@@ -42,6 +42,7 @@ export interface DataSourceTableItem {
export interface ToastMessageItem {
id: string;
defaultMessage: string;
+ success?: boolean;
}
export type DataSourceManagementContextValue = OpenSearchDashboardsReactContextValue<
diff --git a/src/plugins/vis_builder/public/application/components/data_source_select.tsx b/src/plugins/vis_builder/public/application/components/data_source_select.tsx
index c51aa40a08e2..36638e0cb63b 100644
--- a/src/plugins/vis_builder/public/application/components/data_source_select.tsx
+++ b/src/plugins/vis_builder/public/application/components/data_source_select.tsx
@@ -39,7 +39,7 @@ export const DataSourceSelect = () => {
dispatch(setIndexPattern(foundOption.id));
}
}}
- prepend={i18n.translate('wizard.nav.dataSource.selector.title', {
+ prepend={i18n.translate('visBuilder.nav.dataSource.selector.title', {
defaultMessage: 'Data Source',
})}
error={error}
diff --git a/src/plugins/vis_builder/public/application/components/data_tab/field_search.tsx b/src/plugins/vis_builder/public/application/components/data_tab/field_search.tsx
index 62dcf2c2b953..a2dec9156dba 100644
--- a/src/plugins/vis_builder/public/application/components/data_tab/field_search.tsx
+++ b/src/plugins/vis_builder/public/application/components/data_tab/field_search.tsx
@@ -21,7 +21,7 @@ export interface Props {
* Additionally there's a button displayed that allows the user to show/hide more filter fields
*/
export function FieldSearch({ value }: Props) {
- const searchPlaceholder = i18n.translate('wizard.fieldChooser.searchPlaceHolder', {
+ const searchPlaceholder = i18n.translate('visBuilder.fieldChooser.searchPlaceHolder', {
defaultMessage: 'Search field names',
});
diff --git a/src/plugins/vis_builder/public/application/components/experimental_info.tsx b/src/plugins/vis_builder/public/application/components/experimental_info.tsx
index 35ea235c1ba3..ea341e1e8873 100644
--- a/src/plugins/vis_builder/public/application/components/experimental_info.tsx
+++ b/src/plugins/vis_builder/public/application/components/experimental_info.tsx
@@ -14,13 +14,13 @@ export const InfoComponent = () => {
className="hide-for-sharing"
data-test-subj="experimentalVisInfo"
size="s"
- title={i18n.translate('wizard.experimentalInfoTitle', {
+ title={i18n.translate('visBuilder.experimentalInfoTitle', {
defaultMessage: 'This editor is experimental and should not be used in production',
})}
iconType="beaker"
>
{
{newVisType && (
setNewVisType(undefined)}
@@ -78,7 +78,7 @@ export const RightNav = () => {
>
diff --git a/src/plugins/vis_builder/public/application/utils/breadcrumbs.ts b/src/plugins/vis_builder/public/application/utils/breadcrumbs.ts
index 7bdb41075f35..1f5d15a93382 100644
--- a/src/plugins/vis_builder/public/application/utils/breadcrumbs.ts
+++ b/src/plugins/vis_builder/public/application/utils/breadcrumbs.ts
@@ -6,14 +6,14 @@
import { i18n } from '@osd/i18n';
import { VISUALIZE_ID } from '../../../common';
-const defaultEditText = i18n.translate('wizard.editor.defaultEditBreadcrumbText', {
+const defaultEditText = i18n.translate('visBuilder.editor.defaultEditBreadcrumbText', {
defaultMessage: 'Edit',
});
export function getVisualizeLandingBreadcrumbs(navigateToApp) {
return [
{
- text: i18n.translate('wizard.listing.breadcrumb', {
+ text: i18n.translate('visBuilder.listing.breadcrumb', {
defaultMessage: 'Visualize',
}),
onClick: () => navigateToApp(VISUALIZE_ID),
@@ -25,7 +25,7 @@ export function getCreateBreadcrumbs(navigateToApp) {
return [
...getVisualizeLandingBreadcrumbs(navigateToApp),
{
- text: i18n.translate('wizard.editor.createBreadcrumb', {
+ text: i18n.translate('visBuilder.editor.createBreadcrumb', {
defaultMessage: 'Create',
}),
},
diff --git a/src/plugins/vis_builder/public/application/utils/get_top_nav_config.tsx b/src/plugins/vis_builder/public/application/utils/get_top_nav_config.tsx
index 965357e84158..fcf5a20f7dbf 100644
--- a/src/plugins/vis_builder/public/application/utils/get_top_nav_config.tsx
+++ b/src/plugins/vis_builder/public/application/utils/get_top_nav_config.tsx
@@ -69,16 +69,16 @@ export const getTopNavConfig = (
id: 'save',
iconType: savedWizardVis?.id && originatingApp ? undefined : ('save' as const),
emphasize: savedWizardVis && !savedWizardVis.id,
- description: i18n.translate('wizard.topNavMenu.saveVisualizationButtonAriaLabel', {
+ description: i18n.translate('visBuilder.topNavMenu.saveVisualizationButtonAriaLabel', {
defaultMessage: 'Save Visualization',
}),
className: savedWizardVis?.id && originatingApp ? 'saveAsButton' : '',
label:
savedWizardVis?.id && originatingApp
- ? i18n.translate('wizard.topNavMenu.saveVisualizationAsButtonLabel', {
+ ? i18n.translate('visBuilder.topNavMenu.saveVisualizationAsButtonLabel', {
defaultMessage: 'save as',
})
- : i18n.translate('wizard.topNavMenu.saveVisualizationButtonLabel', {
+ : i18n.translate('visBuilder.topNavMenu.saveVisualizationButtonLabel', {
defaultMessage: 'save',
}),
testId: 'wizardSaveButton',
@@ -115,7 +115,7 @@ export const getTopNavConfig = (
emphasize: true,
iconType: 'checkInCircleFilled' as const,
description: i18n.translate(
- 'wizard.topNavMenu.saveAndReturnVisualizationButtonAriaLabel',
+ 'visBuilder.topNavMenu.saveAndReturnVisualizationButtonAriaLabel',
{
defaultMessage: 'Finish editing wizard and return to the last app',
}
@@ -193,7 +193,7 @@ export const getOnSave = (
if (id) {
toastNotifications.addSuccess({
- title: i18n.translate('wizard.topNavMenu.saveVisualization.successNotificationText', {
+ title: i18n.translate('visBuilder.topNavMenu.saveVisualization.successNotificationText', {
defaultMessage: `Saved '{visTitle}'`,
values: {
visTitle: savedWizardVis.title,
@@ -236,7 +236,7 @@ export const getOnSave = (
console.error(error);
toastNotifications.addDanger({
- title: i18n.translate('wizard.topNavMenu.saveVisualization.failureNotificationText', {
+ title: i18n.translate('visBuilder.topNavMenu.saveVisualization.failureNotificationText', {
defaultMessage: `Error on saving '{visTitle}'`,
values: {
visTitle: newTitle,
diff --git a/src/plugins/vis_builder/public/application/utils/use/use_can_save.ts b/src/plugins/vis_builder/public/application/utils/use/use_can_save.ts
index adfb15c03e48..7da320d266f3 100644
--- a/src/plugins/vis_builder/public/application/utils/use/use_can_save.ts
+++ b/src/plugins/vis_builder/public/application/utils/use/use_can_save.ts
@@ -22,7 +22,7 @@ export const useCanSave = () => {
// TODO: Need to finalize the error messages
const getErrorMsg = (isEmpty, hasNoChange, hasDraftAgg) => {
const i18nTranslate = (key: string, defaultMessage: string) =>
- i18n.translate(`wizard.saveVisualizationTooltip.${key}`, {
+ i18n.translate(`visBuilder.saveVisualizationTooltip.${key}`, {
defaultMessage,
});
diff --git a/src/plugins/vis_builder/public/embeddable/disabled_visualization.tsx b/src/plugins/vis_builder/public/embeddable/disabled_visualization.tsx
index be6072c105af..30b5dd5ffa3f 100644
--- a/src/plugins/vis_builder/public/embeddable/disabled_visualization.tsx
+++ b/src/plugins/vis_builder/public/embeddable/disabled_visualization.tsx
@@ -15,14 +15,14 @@ export function DisabledVisualization({ title }: { title: string }) {
{title} }}
/>
diff --git a/src/plugins/vis_builder/public/embeddable/vis_builder_embeddable_factory.tsx b/src/plugins/vis_builder/public/embeddable/vis_builder_embeddable_factory.tsx
index c200efee0d2d..81990d61f2a4 100644
--- a/src/plugins/vis_builder/public/embeddable/vis_builder_embeddable_factory.tsx
+++ b/src/plugins/vis_builder/public/embeddable/vis_builder_embeddable_factory.tsx
@@ -106,7 +106,7 @@ export class WizardEmbeddableFactoryDefinition
}
public getDisplayName() {
- return i18n.translate('wizard.displayName', {
+ return i18n.translate('visBuilder.displayName', {
defaultMessage: PLUGIN_ID,
});
}
diff --git a/src/plugins/vis_builder/public/plugin.ts b/src/plugins/vis_builder/public/plugin.ts
index f4e7b8bebeb5..cd2a4746ace4 100644
--- a/src/plugins/vis_builder/public/plugin.ts
+++ b/src/plugins/vis_builder/public/plugin.ts
@@ -110,8 +110,8 @@ export class WizardPlugin
visualizations.registerAlias({
name: PLUGIN_ID,
title: PLUGIN_NAME,
- description: i18n.translate('wizard.visPicker.description', {
- defaultMessage: 'Create visualizations using the new Drag & Drop experience',
+ description: i18n.translate('visBuilder.visPicker.description', {
+ defaultMessage: 'Create visualizations using the new Visualization Builder',
}),
icon: wizardIconSecondaryFill,
stage: 'experimental',