From 2746d0f530a3e3acb999c8acf472686eda7d88ce Mon Sep 17 00:00:00 2001 From: "Yuanqi(Ella) Zhu" <53279298+zhyuanqi@users.noreply.github.com> Date: Wed, 3 Apr 2024 10:24:55 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Lu Yu Signed-off-by: Yuanqi(Ella) Zhu <53279298+zhyuanqi@users.noreply.github.com> --- .../data_source_management/public/components/utils.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/plugins/data_source_management/public/components/utils.ts b/src/plugins/data_source_management/public/components/utils.ts index 0768a35f135e..eebf7316e3e3 100644 --- a/src/plugins/data_source_management/public/components/utils.ts +++ b/src/plugins/data_source_management/public/components/utils.ts @@ -110,18 +110,20 @@ export function getDefaultDataSource( label: defaultOption?.[0]?.label || defaultOptionDataSource.attributes?.title, }, ]; - } else if (defaultDataSourceAfterCheck) { +} +if (defaultDataSourceAfterCheck) { return [ { id: defaultDataSourceAfterCheck.id, label: defaultDataSourceAfterCheck.attributes?.title || '', }, ]; - } else if (!hideLocalCluster) { + } + if (!hideLocalCluster) { return [LocalCluster]; - } else { + } return []; - } + } export async function getDataSourceById(