Dependencies of plugins are not updated

[jonblack]

Using the following example recipe:

type: specs.openrewrite.org/v1beta/recipe
name: com.my.group.Example
displayName: Example
description: Example
recipeList:
  - org.openrewrite.maven.ChangePluginGroupIdAndArtifactId:
      oldGroupId: com.my.group
      oldArtifactId: app-plugin-artifact
      newGroupId: com.my.group.subgroup
  - org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactId:
      oldGroupId: com.my.group
      oldArtifactId: app-plugin-artifact
      newGroupId: com.my.group.subgroup
  - org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactId:
      oldGroupId: com.my.group
      oldArtifactId: app-plugin-artifact
      newArtifactId: app-plugin-artifact
      newGroupId: com.my.group.subgroup

This fails to update the dependencies of plugins. For example:

<project>
  <modelVersion>4.0.0</modelVersion>

  <groupId>com.app.myapp</groupId>
  <artifactId>awesome-app</artifactId>
  <version>1.0.0</version>

  <build>
    <plugins>
      <plugin>
        <groupId>com.app.plugins</groupId>
        <artifactId>cool-plugin</artifactId>
        <version>1.0.0</version>
        <dependencies>
          <dependency>
            <groupId>com.my.group</groupId>
            <artifactId>app-plugin-artifact</artifactId>
            <version>1.1.0</version>
          </dependency>
        </dependencies>
      </plugin>
    </plugins>
  </build>
</project>

I would expect at least one of these recipes to update the groupId of the plugin dependency. If there is a recipe that can do this, it's not clear to me which one it would be.

[timtebeek]

hi @jonblack ! Long time no see; hope you're well! Had a brief look at the above; indeed looks like we do not yet change plugin dependencies; we'd need a similar change as was done here:

• Upgrade Maven plugin dependencies #3481

Of the options above, ChangeDependencyGroupIdAndArtifactId seems the best candidate. Would you be open to getting that started on a draft PR by copying this test to include your example above?

rewrite/rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java

Lines 29 to 99 in 637266b

	@Test
	void changeDependencyGroupIdAndArtifactId() {
	rewriteRun(
	spec -> spec.recipe(new ChangeDependencyGroupIdAndArtifactId(
	"javax.activation",
	"javax.activation-api",
	"jakarta.activation",
	"jakarta.activation-api",
	null,
	null
	)),
	pomXml(
	"""
	<project>
	<modelVersion>4.0.0</modelVersion>
	<groupId>com.mycompany.app</groupId>
	<artifactId>my-app</artifactId>
	<version>1</version>
	<dependencies>
	<dependency>
	<groupId>javax.activation</groupId>
	<artifactId>javax.activation-api</artifactId>
	</dependency>
	</dependencies>
	<dependencyManagement>
	<dependencies>
	<dependency>
	<groupId>javax.activation</groupId>
	<artifactId>javax.activation-api</artifactId>
	<version>1.2.0</version>
	</dependency>
	<dependency>
	<groupId>jakarta.activation</groupId>
	<artifactId>jakarta.activation-api</artifactId>
	<version>1.2.1</version>
	</dependency>
	</dependencies>
	</dependencyManagement>
	</project>
	""",
	"""
	<project>
	<modelVersion>4.0.0</modelVersion>
	<groupId>com.mycompany.app</groupId>
	<artifactId>my-app</artifactId>
	<version>1</version>
	<dependencies>
	<dependency>
	<groupId>jakarta.activation</groupId>
	<artifactId>jakarta.activation-api</artifactId>
	</dependency>
	</dependencies>
	<dependencyManagement>
	<dependencies>
	<dependency>
	<groupId>javax.activation</groupId>
	<artifactId>javax.activation-api</artifactId>
	<version>1.2.0</version>
	</dependency>
	<dependency>
	<groupId>jakarta.activation</groupId>
	<artifactId>jakarta.activation-api</artifactId>
	<version>1.2.1</version>
	</dependency>
	</dependencies>
	</dependencyManagement>
	</project>
	"""
	)
	);
	}

[jonblack]

Hey @timtebeek! Small world! I'm good; very busy. How are you?

I've created the pull request with the test case that reproduces the issue. Sadly, I don't have time to work on a fix at the moment. Hopefully, this will help someone who can pick it up.

[timtebeek]

All is well here, thanks! I know some colleagues of yours were active as well. Hope the automations help your save time.

Thanks for the runnable exmaple! Indeed makes this easier to take on. Can't fit it in today but I'll try to find some time for this.

[timtebeek]

• Fixed in fix[maven]: update plugin dependencies #4798