Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop HasSourcePath in favor of FindSourceFiles #3755

Closed
3 tasks done
timtebeek opened this issue Dec 2, 2023 · 1 comment · Fixed by #3758
Closed
3 tasks done

Drop HasSourcePath in favor of FindSourceFiles #3755

timtebeek opened this issue Dec 2, 2023 · 1 comment · Fixed by #3758
Assignees
@timtebeek
Labels
enhancement New feature or request

Comments

@timtebeek
Copy link
Contributor

timtebeek commented Dec 2, 2023 •
edited
Loading

What problem are you trying to solve?

Both recipes do the same in slightly different ways; rather than maintain both we want to only have one going forward.
Logging here, but should also be updated downstream.

Describe the solution you'd like

HasSourcePath fully removed, here and downstream, where it can be replaced with FindSourceFiles.

  • Evaluate if any downstream projects use the HasSourcePath regex option, and if so add that to FindSourceFiles.
  • Replace HasSourcePath with FindSourceFiles downstream.
  • Remove HasSourcePath here.

Additional context
@timtebeek timtebeek added the enhancement New feature or request label Dec 2, 2023
@timtebeek timtebeek self-assigned this Dec 2, 2023
@timtebeek timtebeek moved this to In Progress in OpenRewrite Dec 2, 2023
This was referenced Dec 2, 2023
Merged
Merged
@timtebeek
Copy link
Contributor Author

Turns out HasSourcePath supported {.md,.txt} syntax, which FindSourceFiles does not (yet) support. Worked around this in downstream projects where we saw test failures; did not spot this elsewhere.

@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Dec 4, 2023
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Dec 4, 2023
@nmck257 nmck257 mentioned this issue Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop HasSourcePath in favor of FindSourceFiles openrewrite/rewrite
1 participant
@timtebeek