Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if depends on code generation #433

Closed
tisonkun opened this issue Nov 11, 2022 · 2 comments
Closed

Fail if depends on code generation #433

tisonkun opened this issue Nov 11, 2022 · 2 comments

Comments

@tisonkun
Copy link

tisonkun commented Nov 11, 2022

Adding:

      <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>4.36.0</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.java.cleanup.Cleanup</recipe>
          </activeRecipes>
        </configuration>
      </plugin>

to the root pom.xml and configure (Thanks to #103):

  <pluginGroups>
        <pluginGroup>org.openrewrite.maven</pluginGroup>
  </pluginGroups>

to .m2/settings.xml.

Running mvn rewrite:run under the root path of http://github.com/apache/pulsar, gives:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project pulsar-client-1x: Compilation failure: Compilation failure: 
[ERROR] /Users/chenzili/Brittani/pulsar/pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/impl/v1/ReaderV1Impl.java:[30,56] package org.apache.pulsar.shade.client.api.v2 does not exist
[ERROR] /Users/chenzili/Brittani/pulsar/pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/impl/v1/ReaderV1Impl.java:[32,62] package org.apache.pulsar.shade.client.api.v2 does not exist
[ERROR] /Users/chenzili/Brittani/pulsar/pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/impl/v1/ConsumerV1Impl.java:[31,56] package org.apache.pulsar.shade.client.api.v2 does not exist
[ERROR] /Users/chenzili/Brittani/pulsar/pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/impl/v1/ConsumerV1Impl.java:[33,64] package org.apache.pulsar.shade.client.api.v2 does not exist
@tisonkun
Copy link
Author

Fixed by first mvn clean install -DskipTests.

@tisonkun tisonkun closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2022
@tisonkun tisonkun moved this to Done in OpenRewrite Nov 11, 2022
@tisonkun
Copy link
Author

Another issue:

[ERROR] Failed to execute goal org.openrewrite.maven:rewrite-maven-plugin:4.36.0:run (default-cli) on project pulsar-client-admin-shade-test: Execution default-cli of goal org.openrewrite.maven:rewrite-maven-plugin:4.36.0:run failed: java.lang.StackOverflowError -> [Help 1]

The same settings as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant