Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide rewrite as an extension instead of or in addition to a plugin #405

Closed
cproinger opened this issue Aug 1, 2022 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@cproinger
Copy link

i habe a multi-module maven project where the root is not the parent the submodules. that way i have to define the rewrite-plugin in all parent poms. I'm no expert on this, but wouldn't it make more sense to provide rewrite as an extension instead/in-addition-to a plugin?

@tkvangorder tkvangorder moved this to Backlog in OpenRewrite Aug 9, 2022
@tkvangorder
Copy link
Contributor

Thank you for the suggestion, I have added this to our backlog for discovery.

@timtebeek timtebeek changed the title Freature Request: maven extension? Provide rewrite as an extension instead of or in addition to a plugin Nov 29, 2023
@timtebeek
Copy link
Contributor

Since this issue was opened we've updated the docs to include instructions for running OpenRewrite without adding anything to the pom.xml file. See for instance: https://docs.openrewrite.org/recipes/java/migrate/upgradepluginsforjava21

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.migrate.UpgradePluginsForJava21 -Drewrite.exportDatatables=true

There had been some issues with multi module projects previously, but those have also been resolved:

With that I think there's less of a need to work out whether we can make the plugin work as an extension, as we try to limit the number of ways folks may use the project, as we'd then have to document, maintain and support those options going forward.

@timtebeek timtebeek closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants