Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested_corrections #47

Open
CloeDavid opened this issue Dec 5, 2023 · 3 comments
Open

suggested_corrections #47

CloeDavid opened this issue Dec 5, 2023 · 3 comments

Comments

@CloeDavid
Copy link

I noticed some warnings and errors when started using TINT. I'm working with Python 3.9 and I updated recently most of the common packages (numpy, pandas, xarray, etc)

I'd like to suggest some updates.

@CloeDavid
Copy link
Author

CloeDavid commented Dec 5, 2023

TINT/tint/grid_utils.py

Lines 46 to 48 in 49dddec

def get_grid_alt(grid_size, alt_meters=1500):
""" Returns z-index closest to alt_meters. """
return np.int(np.round(alt_meters/grid_size[0]))

In line 48 np.int( ) is now deprecated and needs to be simply replaced by int( )

@CloeDavid
Copy link
Author

from boto.s3.connection import S3Connection

boto module is not in the required dependencies (user have to download it after an error message).
Also boto is no more supported as boto3 has replaced it.

@zssherman
Copy link
Collaborator

zssherman commented Dec 5, 2023

@CloeDavid Thanks for the heads up! Yeah development has slowed here as TINT is currently being integrated into tobac https://github.com/tobac-project/tobac/tree/v2.0-dev version 2.0. I'll make the changes now to fix those two depreciations for now. We do recommend moving towards tobac as development is mostly focused there now. Thanks again for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants