Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for soft/hard quarantine periods #10

Closed
coriaweb opened this issue Jun 28, 2018 · 5 comments
Closed

Add support for soft/hard quarantine periods #10

coriaweb opened this issue Jun 28, 2018 · 5 comments
Milestone

Comments

@coriaweb
Copy link
Contributor

Correct the automation of the cron, for the grace periods and the redemption period.

He's currently changing it to canceled.

@wmetge
Copy link
Contributor

wmetge commented Oct 23, 2018

hi @coriaweb, we will look into adding the correct mapping for these statuses

@willdashwood
Copy link

I was about to post a new issue but found this old one. I think that the setting of statuses in the domain sync cron script just needs a little tweaking with it's logic now that WHMCS supports more than previously.

Ideally the OpenProvider API should be improved so that we get more than 1 domain status (DEL) for domains that have expired. I will ask Inna at OP if this could be added to the API. @soberoctober are you just working on the WHMCS module or do you work on the API as well?

Assuming that the OP API can't be improved at this stage to provide more details status information, I think that the domain sync script should first check if "Domain Grace and Redemption Fees" is enabled under General Settings. If it is enabled and the domain status is already set to "Grace" or "Redemption" in WHMCS, do not update unless status in OP changes to something other the DEL (e.g. ACT).

Putting some logic control in there rather than just updating the status to Expired might be the best way of handling it for now.

@willdashwood
Copy link

Just updating this issue now that I've had a reply from Inna. She tells me that you can already tell if a domain is in grace or redemption depending on if softQuarantineExpiryDate or hardQuarantineExpiryDate is returned when calling searchDomainRequest. Although admittedly it doesn't state that in the documentation:

https://doc.openprovider.eu/API_Module_Domain_searchDomainRequest

I wonder what else is undocumented that might be of use for other issues such as #39 or #32

@soberoctober
Copy link
Contributor

@willdashwood @coriaweb

we're assessing the possibility of tracking these statuses in the module.
i'll post an update once we come up with a working proposal.

@soberoctober soberoctober changed the title Error period Add support for soft/hard quarantine periods Apr 2, 2019
@soberoctober soberoctober added this to the 2.4 milestone May 14, 2019
@soberoctober
Copy link
Contributor

6827882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants