Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest EPUBCheck v. 5.1.x #857

Closed
karenhanson opened this issue May 26, 2023 · 2 comments · Fixed by #905
Closed

Upgrade to latest EPUBCheck v. 5.1.x #857

karenhanson opened this issue May 26, 2023 · 2 comments · Fixed by #905
Milestone

Comments

@karenhanson
Copy link
Contributor

karenhanson commented May 26, 2023

EPUB 3.3 is now released along with an updated EPUBCheck v.5.1.x. Both are backward compatible with prior versions. The EPUB module needs to be updated to support the latest version. More info here: https://www.w3.org/2023/05/pressrelease-epub33-rec.html.en

Note: I plan to work on this when I have a chance, so please feel free to assign this to me! :)

@karenhanson karenhanson changed the title Upgrade to latest EPUBCheck v. 5.01 Upgrade to latest EPUBCheck v. 5.0.1 May 26, 2023
@karenhanson
Copy link
Contributor Author

karenhanson commented Jun 12, 2023

I started this change on my branch: https://github.com/karenhanson/jhove/tree/update-to-epub-5-0-1
I had to make some changes to get the tests working. The biggest concern I have is that FontFile boolean might not be reporting accurate information. Assuming I'm understanding its purpose correctly, it appears to always be false regardless of whether the font file is embedded. I've logged an issue with EPUBCheck. You can see notes about this and other changes on this commit comment: f360f8c
I'll come back to this in a few months and decide what to do about FontFile based on whether there is a response to the issue I logged.

@karenhanson
Copy link
Contributor Author

karenhanson commented Jul 7, 2023

Update: EPUBCheck released 5.1.0, which fixed the font issue and reverted a change that was causing resources not to be listed. I have therefore jumped to 5.1.0:
karenhanson@412e4ab
This is almost ready for a PR, except I noticed that the report no longer includes Creation Date so I logged an issue to see if it was likely to be added back in. Turns out they will add it in to the next maintenance release (presumably 5.1.1). I don't think this will take too long, so I'll watch for that release. Once it's out I'll wrap this up and do a PR.

@karenhanson karenhanson changed the title Upgrade to latest EPUBCheck v. 5.0.1 Upgrade to latest EPUBCheck v. 5.1.x Nov 9, 2023
@carlwilson carlwilson linked a pull request Mar 4, 2024 that will close this issue
@carlwilson carlwilson added this to the JHOVE 1.30 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants