Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query system: long query messages are hard to read with the new DT::datatable() defaults #91

Closed
LDSamson opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@LDSamson
Copy link
Collaborator

Line wrapping is now disabled which is undesirable:

image

image

@LDSamson LDSamson self-assigned this Sep 19, 2024
@LDSamson LDSamson added the enhancement New feature or request label Sep 19, 2024
@LDSamson LDSamson added this to the v0.1.0 milestone Sep 19, 2024
@jthompson-arcus
Copy link
Collaborator

This is a result of using the Scroller extension for DataTables. It requires all row heights to be the same. I see a few possible paths forward.

  1. Adjust the defaults for a few select tables (such as the one pictured above).
  2. Use another plugin like elipsis to truncate long text (still available in tooltip). I could see this as a solution combined with (1), where a table like the queries will have full text and word wrap.
  3. Remove the use of Scroller.

Issue with (1) is it can be hard to know which table the end user would want to adjust this default for.
Issue with (2) is that we are adding another plugin. Plus it doesn't really address the problem pictured above without being combined with another solution.
Issue with (3) is that we lose the dynamic rendering. Personally I think removing the paging is a high value add from a user perspective. If we keep the Y-scroll then we need to be mindful about how much data can be rendered at one time. It is unclear if this is a problem or not with how the app is constructed. Also, we would need to come up with a solution for column widths in wide tables.

@LDSamson
Copy link
Collaborator Author

@jthompson-arcus Thanks for your input. I like the use of scroller in most of the tables. It's just in these two tables that it can be a bit problematic for long query texts.

For now, I think a solution such as 1) and 2) would be nice indeed. I am at the moment finishing a PR that actually does a combination of 1) and 2). However, I saw the ellipsis plugin too late so I implemented something similar (but much less fancy) as no 2) by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants