Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X25519 Subkey for Ed25519 Test Vector #158

Open
TJ-91 opened this issue Nov 8, 2024 · 3 comments
Open

Add X25519 Subkey for Ed25519 Test Vector #158

TJ-91 opened this issue Nov 8, 2024 · 3 comments

Comments

@TJ-91
Copy link
Collaborator

TJ-91 commented Nov 8, 2024

Currently we only have a PQ/T encryption subkey for the A.1. test vector. Wouldn't it make sense to add an X25519 subkey?

@falko-strenzke
Copy link
Collaborator

For what reason do you want to add the traditional subkey?

@TJ-91
Copy link
Collaborator Author

TJ-91 commented Nov 8, 2024

I suppose the test vector is meant as an illustration of the case that is described in 8.2. Key generation strategies (Point 2).

In a typical scenario, the owner of the certificate would like to enable PQ(/T) encryption, while remaining compatible with PQ(/T)-incapable clients. Not having a traditional encryption subkey limits the general usability of the certificate for non-PQ(/T) clients. It is therefore not something that I would expect in a typical certificate.

While not critical, I think it's good if the test vectors reflect what we expect to see in the wild.

@wussler
Copy link
Collaborator

wussler commented Nov 13, 2024

Also switch the same test vector to use PKESK v3 and SEIPD v1 for completeness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants