Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests that test just the build process #331

Open
dario-piotrowicz opened this issue Feb 3, 2025 · 0 comments
Open

Add e2e tests that test just the build process #331

dario-piotrowicz opened this issue Feb 3, 2025 · 0 comments

Comments

@dario-piotrowicz
Copy link
Contributor

dario-piotrowicz commented Feb 3, 2025

When applications are build using the adapter there are a few things that can happen in the terminal:

  • some prompts (e.g. for creating missing open-next and wrangler config files)
  • logs (e.g. workers saved at: )
  • build errors occur (e.g. getCloudflareContext being used in an SSG'd route)

These things can't be tested in our playwright e2es since they simply rely on a preview command and test the application's functionalities, so ideally we should create a new set of "lower level" e2es that can test the build aspect of the adapter itself.

Additionally with this we can also test that files have been correctly saved onto the filesystem (e.g. handler.mjs.meta.json).


Original conversation: #330 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant