fix(aws): add missing base path to data routes

[alebelcor]

Related #670

I was trying to figure out how to add (and run) a unit test in matcher.test.ts but then I saw this issue that mentions all unit tests are broken (?).

If e2e test(s) are required I'd appreciate any help as I'm not very familiar. And let me know if you need something else.

Thanks!

[changeset-bot]

🦋 Changeset detected

Latest commit: 57f4814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@opennextjs/aws	Patch
app-pages-router	Patch
app-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sommeeeer]

Unit tests should work again. I guess you could have one inside here:

opennextjs-aws/packages/tests-unit/tests/core/routing/matcher.test.ts

Line 471 in 3f85a90

describe("fixDataPage", () => {

[conico974]

No unit test run just fine.
In packages/tests-unit just run pnpm run dev.
You'll have to add a test here

opennextjs-aws/packages/tests-unit/tests/core/routing/matcher.test.ts

Line 471 in 3f85a90

describe("fixDataPage", () => {

and modify NextConfig as in here

opennextjs-aws/packages/tests-unit/tests/core/routing/matcher.test.ts

Line 228 in 3f85a90

NextConfig.skipTrailingSlashRedirect = true;

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@672

commit: 57f4814

[alebelcor]

Added two tests. Test suite seems to run successfully.

Let me know if those are redundant, or you'd rather me add the base path to existing tests instead. I'm happy to update it as you see fit.

[conico974]

https://github.com/opennextjs/opennextjs-aws/actions/runs/12284689715/job/34281243192?pr=672
Run pnpm biome check --fix at the root of the repo

[sommeeeer]

Looks like it failed on write permission reporting the test coverage in actions/test

[alebelcor]

So weird, a test started failing locally for some reason now.

[conico974]

@alebelcor I think the reset are done on each describe, not on each test inside describe

[sommeeeer]

if you add this under line 471 it seems to work here. might be that the global beforeEach() will only reset on each describe, but if its inside a describe it will make it reset on each it:

beforeEach(()=> {
  NextConfig.basePath = undefined;
})

[sommeeeer]

LGTM, thanks!

[conico974]

LGTM Thanks