Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /study/{id} #51

Open
Tracked by #50
PGijsbers opened this issue Oct 10, 2023 · 6 comments
Open
Tracked by #50

GET /study/{id} #51

PGijsbers opened this issue Oct 10, 2023 · 6 comments
Labels
Collections Collection endpoints GET GET endpoints Migration Already exists in the old API
Milestone
v1.0

Comments

@PGijsbers
Copy link
Contributor

No description provided.

@PGijsbers PGijsbers mentioned this issue Oct 10, 2023
Open
6 tasks
@PGijsbers PGijsbers added Migration Already exists in the old API Collections Collection endpoints GET GET endpoints labels Oct 10, 2023
@PGijsbers PGijsbers added this to the v1.0 milestone Oct 10, 2023
@PGijsbers
Copy link
Contributor Author

🪲 administrators can not access private datasets

@PGijsbers
Copy link
Contributor Author

I decided to not support legacy studies in the new implementation. The php code already says TODO: remove ASAP. We would need to have a look at how to migrate the legacy studies to new-style studies (if at all - legacy studies may have things attached that modern studies can't, such as flows).

@PGijsbers
Copy link
Contributor Author

PGijsbers commented Dec 15, 2023 •
edited
Loading

❓What is the benchmark_suite identifier in the study table? Is it a field for run studies to link to a task study?

@PGijsbers PGijsbers added the ask_jan Denotes the thread contains an unanswered question to ask Jan van Rijn label Dec 15, 2023
@PGijsbers
Copy link
Contributor Author

⚠️ Current implementation of run studies is not tested, requires updated test database that contains run study (and runs).

@PGijsbers PGijsbers mentioned this issue Dec 15, 2023
Merged
@PGijsbers
Copy link
Contributor Author

Migrate legacy studies in database.

@PGijsbers
Copy link
Contributor Author

❓What is the benchmark_suite identifier in the study table? Is it a field for run studies to link to a task study?

The column is not used (in production), we can delete it.

@PGijsbers PGijsbers mentioned this issue Jul 12, 2024
Open
2 tasks
@PGijsbers PGijsbers removed the ask_jan Denotes the thread contains an unanswered question to ask Jan van Rijn label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Collections Collection endpoints GET GET endpoints Migration Already exists in the old API
Projects
Roadmap (high level)
Status: No status
Milestone
v1.0
Development

No branches or pull requests
1 participant
@PGijsbers