code styles fix #233
Merged
code styles fix #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunghanjacktsai
approved these changes
Sep 15, 2022
tsunghanjacktsai
requested changes
Sep 15, 2022
RongtongJin
reviewed
Sep 15, 2022
| @@ -675,10 +675,14 @@ private void doTruncate(long truncateIndex) throws Exception { | |||
| PreConditions.check(type.get() == PushEntryRequest.Type.TRUNCATE, DLedgerResponseCode.UNKNOWN); | |||
| DLedgerEntry truncateEntry = dLedgerStore.get(truncateIndex); | |||
| PreConditions.check(truncateEntry != null, DLedgerResponseCode.UNKNOWN); | |||
|
|
|||
| assert truncateEntry != null; | |||
There was a problem hiding this comment.
Why should we check again here?
There was a problem hiding this comment.
Why should we check again here?
我继续检查一下其他代码
| @@ -419,20 +419,20 @@ public EntryDispatcher(String peerId, Logger logger) { | |||
|
|
|||
| private boolean checkAndFreshState() { | |||
There was a problem hiding this comment.
This is mainly to check whether it is the master, so I think the original logic is more smooth
There was a problem hiding this comment.
总觉得非操作会使逻辑计算变得复杂，这里换一个方法名可以吗？把不为master体现出来
There was a problem hiding this comment.
总觉得非操作会使逻辑计算变得复杂，这里换一个方法名可以吗？把不为master体现出来
可以的哈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
处理了代码里面明显的警告