Adjust for secondary particle energy directly in heating scores #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
changed the title
|
I'm not getting better results:
|
|
@SteSeg hrmm I certainly thought this would help. Are you still getting negative photon heating values? Would you be willing to drop the OpenMC header from those runs in here? |
|
Yes, I'm still getting negative contributions from photons but it might be indeed that I'm not correctly checking out this pr: |
|
This seems to have resolved my transport issues, at least it is no longer segfaulting. @SteSeg I agree it looks like you are not using the version of OpenMC in this PR. |
|
My bad. It works indeed! This is the situation now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #3207 by adjusting heating scores using the sum of secondary particle energy rather than a placeholder for how many secondaries were produced by the latest reaction. Namely, the attribute
Particle::n_bank_secondary_is replaced withParticle::bank_second_E_to track how much heating scores should be decremented when secondary particles are generated and will be transported independently.This also contains a fix for a pathway by which particles were revived from particles in the secondary bank but the original attribute was not reset correctly. This line has been added in
Particle::event_revive_from_secondary.The previous method was more general and I think we should keep it in mind for the future if other/additional information needs to be gathered from the latest secondaries, but updating to this method will avoid the problems we're seeing evidence of when photon transport is enabled with weight windows applied.
Fixes #3207
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)