Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename max_split parameters. #2308

Closed
pshriwise opened this issue Nov 22, 2022 · 2 comments
Closed

Rename max_split parameters. #2308

pshriwise opened this issue Nov 22, 2022 · 2 comments

Comments

@pshriwise
Copy link
Contributor

There's currently a max_split parameter on both the Settings and WeightWindow classes. The parameter on settings limits the number of times a particle can be split over its entire history and the other limits the number of splits per weight window chcek.

Renaming these parameters for to distinguish them by their purpose would be helpful.
@shimwell
Copy link
Member

shimwell commented Dec 1, 2022

How about lifetime_max_splits and max_splits_per_ww

@paulromano
Copy link
Contributor

Closed by #2954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulromano @pshriwise @shimwell