ol.Interaction.Modify fixes #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in ol.interaction.Modify when trying to delete nodes on a geometry that has duplicate nodes. A bug occurs when clicking on the duplicate node.
This commit fixes the bug that occurs when trying to modify a closed LineString by clicking on the starting/ending node. Such a closed line is added to the modify-test example.
Prevent vertexFeature_ from ol.interaction.Modify from being selected by ol.interaction.Select. The bug occurs when an delete attempt fails. ex: clicikng on the first or last node of LineString, or clicking a line segment between two nodes.
handlePointerMove_ doesn't need to be called when dragging. handleDragEvent_ takes care of the event in that case. in handleDragEvent_, createOrUpdateVertexFeature_ doesn't need to be called for each dragged segment. it can be called only once with current vertex. fixes made to pass the build
Merged
ahocevar
added a commit
to openlayers/cla
that referenced
this pull request
Mar 25, 2015
Thanks @fperucic for openlayers/openlayers#3395 and any contributions you can make.
fperucic
added a commit
to fperucic/ol3
that referenced
this pull request
Mar 25, 2015
fix snap for ol.interaction.Modify
| * @param {ol.interaction.SegmentDataType} b | ||
| * @return {number} | ||
| */ | ||
| function sorter(a, b) { return a.index - b.index; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fixes,
extended examples/modify-test.js with specific use cases