Support wrapX for attributions #3377
Conversation
ahocevar
force-pushed
the
attribution-wrapx
branch
from
63a5ada to
585deef
Compare
| * @param {Object.<string, ol.TileRange>} tileRanges Tile ranges. | ||
| * @param {ol.tilegrid.TileGrid=} opt_tileGrid Tile grid. | ||
| * @param {ol.proj.Projection=} opt_projection Projection. |
There was a problem hiding this comment.
Any reason for making tileGrid and projection optional arguments? As far as I can tell, intersectsAnyTileRange is always passed a tile grid and a projection.
There was a problem hiding this comment.
We could even use {!ol.tilegrid.TileGrid} and {!ol.proj.Projection} and avoid testing whether tileGrid and projection are null in the code.
There was a problem hiding this comment.
Ok, I can change that. Good point.
There was a problem hiding this comment.
The type check has to happen somewhere. I pushed another commit that implements your suggested changes. Let me know which one you like better.
|
What do you think about https://github.com/elemoine/ol3/commit/6080f864bfc3f6c0bb6faf784975491dd5bc6de8? If you agree with my commit could you please merge the three commits into one before merging? |
ahocevar
force-pushed
the
attribution-wrapx
branch
from
391d1df to
055f0fe
Compare
|
Please merge when the build passes on Travis. Thanks! |
ahocevar
force-pushed
the
attribution-wrapx
branch
from
055f0fe to
d9c04cd
Compare
Support wrapX for attributions
The intersection tests for attributions currently fail when testing against tile ranges from an extent of a view that wraps the x-axis. This is fixed by letting attributions know about the world extent.
Fixes #999.