Add will-change CSS properties #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +89,9 @@ ol.Overlay = function(options) { | |||
| */ | |||
| this.element_ = goog.dom.createElement(goog.dom.TagName.DIV); | |||
| this.element_.style.position = 'absolute'; | |||
| if (goog.isDef(this.element_.style.willChange)) { | |||
| this.element_.style.willChange = 'bottom, left, right, top'; | |||
| } | |||
There was a problem hiding this comment.
this.element_ will be null here if #2594 gets merged.
fredj
force-pushed
the
will-change
branch
2 times, most recently
from
bd1eda2 to
0f7df18
Compare
|
Changed the implementation for css only solution |
fredj
force-pushed
the
will-change
branch
2 times, most recently
from
212257a to
09d21f0
Compare
fredj
changed the title
|
@fredj are you interested in continuing this work? Closing for now. Feel free to reopen if you want to work on this again. |
|
This PR is ready |
|
Looks good to me. Please. PS: I hope this won't break anything. |
|
I'll wait for #2594 before merging |
|
Makes sense. |
fredj
force-pushed
the
will-change
branch
2 times, most recently
from
80f43e5 to
52959ab
Compare
|
This has waited for a long time now. If no objection is raised I'll merge this PR. |
|
Yep, please merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Chrome 37; with this property the overlays are rendered into their own rendering layer.
This can be seen by checking the "Show composited layer borders" in the chrome dev tools