Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any paragraph after a list item is added as another list item #160

Closed
jtrein opened this issue Jun 27, 2019 · 4 comments
Closed

Any paragraph after a list item is added as another list item #160

jtrein opened this issue Jun 27, 2019 · 4 comments
Assignees
Labels
bug Something isn't working review

Comments

@jtrein
Copy link

jtrein commented Jun 27, 2019

Mentioned in #bugs on Slack June 27, 2019

If you add a list ^ (creates a <ul><li>...</li></ul> after parse) then any paragraph that comes after the list is embedded inside the <ul> as a list item. It makes reliable styles for lists in PDFs impossible.

^ list item
^ list item

Just some paragraph.

The reason we may not have noticed is because Word docs look great, and the web preview output isn't so noticeable as you can see below.

Screen Shot 2019-06-27 at 1 24 37 PM

@jtrein jtrein added the bug Something isn't working label Jun 27, 2019
@jdville03
Copy link
Member

This might be a good one to prioritize for markup-language cleanup because it's been an issue for a long time and often a point of frustration with users trying to format their agreements correctly.

@outkaj outkaj self-assigned this Aug 6, 2019
@outkaj
Copy link
Contributor

outkaj commented Aug 8, 2019

I have a PR fix up for this. Once it gets an approving review, I'll let you know @jtrein, if you'd be interested in testing the fix out with elements etc.

@jtrein
Copy link
Author

jtrein commented Aug 8, 2019

Sure thing! Thank you.

@outkaj
Copy link
Contributor

outkaj commented Aug 9, 2019

fix has been merged and will be available in next version of ol core / client

@outkaj outkaj closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review
Projects
None yet
Development

No branches or pull requests

3 participants