Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent date formats in changelog #300

Closed
perrinjerome opened this issue Dec 4, 2022 · 2 comments
Closed

Inconsistent date formats in changelog #300

perrinjerome opened this issue Dec 4, 2022 · 2 comments

Comments

@perrinjerome
Copy link
Contributor

Recent entries are in D/MM/YYYY format:

## [1.0.0] - 2/12/2022

Older entries were in MM/DD/YYYY format

## 0.7.2 - 12/28/2018

From CHANGELOG.md:

The format is based on [Keep a Changelog][keepachangelog],

Keep a Changelog recommends YYYY-MM-DD format.

Confusing Dates

Regional date formats vary throughout the world and it's often difficult to find a human-friendly date format that feels intuitive to everyone. The advantage of dates formatted like 2017-07-17 is that they follow the order of largest to smallest units: year, month, and day.

maybe it would be better to switch to YYYY-MM-DD ?

@tombh
Copy link
Collaborator

tombh commented Dec 5, 2022

I'd like to propose that Pygls starts using an automatic CHANGELOG generator, such as https://github.com/orhun/git-cliff. And that we require Conventional Commits messages. The CHANGELOG file doesn't have to be auto-populated in CI, although I would like to try that at first. More than anything I would just like it to be populated by a standard tool and we could edit it after the auto-population.

@tombh
Copy link
Collaborator

tombh commented Oct 12, 2023

This was fixed in #349 by automating with https://github.com/orhun/git-cliff

@tombh tombh closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants