Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] partition support config like 100% - num #1038

Closed
shiyan2016 opened this issue Jul 26, 2022 · 4 comments
Closed

[feature request] partition support config like 100% - num #1038

shiyan2016 opened this issue Jul 26, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@shiyan2016
Copy link
Member

What would you like to be added:

partition support config like 100% - num

Why is this needed:
In some case, we need canary release, which expect num(for example num=1) of pods always keep the newest version even if hpa triggle scale in the canary release time.

@veophi
Copy link
Member

veophi commented Jul 26, 2022

sounds good!

How about to support both 100%-num and 100%-percent ?

@FillZpp
Copy link
Member

FillZpp commented Jul 26, 2022

This should be a topic of the community meeting this week :)

@stale
Copy link

stale bot commented Oct 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 24, 2022
@stale stale bot closed this as completed Nov 1, 2022
@shiyan2016 shiyan2016 reopened this Nov 14, 2022
@stale stale bot removed the wontfix This will not be worked on label Nov 14, 2022
@shiyan2016 shiyan2016 assigned shiyan2016 and unassigned FillZpp Nov 14, 2022
@shiyan2016
Copy link
Member Author

shiyan2016 commented Nov 14, 2022

After discussion,partition will support config with float to improve precision.

@zmberg zmberg added this to the v1.4 milestone Feb 14, 2023
@zmberg zmberg added kind/enhancement New feature or request approved and removed approved labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants