Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-submission enquiry #1162

Closed
ExtremOPS opened this issue Dec 1, 2022 · 9 comments
Closed

Pre-submission enquiry #1162

ExtremOPS opened this issue Dec 1, 2022 · 9 comments

Comments

@ExtremOPS
Copy link

Dear JOSS-editors,

my coworker and I are the maintainer of OSAFT. We already published versoin 0.9.x in FrontiersInPhysics last year.

Since then we added new freatures and models. The review for the first publication in FrontiersIn was probably more concerned with the "usefulness" and "demand" for this software rather than its code quality and methodology. We would really like to submit a new version 1.4.x to JOSS. Would that be possible?

@ExtremOPS
Copy link
Author

Dear JOSS-editors,

I wanted to ask if you have any information regarding my request for us.

Thank you in advance

@arfon
Copy link
Member

arfon commented Feb 13, 2023

While we do allow multiple publications for a given piece of software, we'd expect this to be a major new release. Can you share more information about the changes that have been made to the software since the earlier article?

A link to a diff on GitLab would could be a helpful way to illustrate the changes.

@ExtremOPS
Copy link
Author

Hi @arfon,

thank you for your response 👍🏽. Before I come to the answer, let me quickly explain what the purpose of the software is.

In the domain of acoustophoresis - particle manipulation by means of sound waves - one of the most wanted information is the direction and magnitude of the so-called acoustic radiation force (ARF) which appears due scattering of the acoustic wave at the surface of the suspended particle. There are a handful theories that solve this problem for different approximations of the scatterer (e.g., rigid, inviscid-fluid like, viscous, thermo-viscous), the suspending medium (e.g., inviscid, viscous, visco-elastic), and approximations of the relative size of the scatterer to the acoustic wavelength.

Our aim with OSAF is it to gather as many theories with a common easy interface such that the user can easily compare and compute the ARF for different theories and so on.

Since the last publication which was v.0.9.14 we are at the moment with releases at v1.3.8. The differences since then can be seen here. A summary of the implemented changed since the laste publication is

  • Hasegawa (1969) model added (frontend)
  • Doinikov (2021) viscous part of model added (frontend)
  • Velocity potential and pressure plots added (frontend)
  • General Solution to Doinikov (1994) models added (frontend)
  • Simplified unit testing (backend)
  • Doinikov (2021) viscoelastic scattering field added (frontend)

with the following planned additions before we would submit to JOSS

  • Karlsen (2015) model (frontend)
  • Streamingplots for viscous part of Doinikov (2021) (frontend)
  • Re-factoring of plotting capabilities to make code more maintainable (backend)

I hope, I could express the current and planned changes well enough to give you a general overview. If you need more (detailed) information do not hesitate to contact us again.

Thank you very much!

@danielskatz
Copy link
Collaborator

Can you give us some idea of the number of months between the earlier publication and this planned one? And the amount of new code that you expect?

@ExtremOPS
Copy link
Author

Hi @danielskatz,

the last publication was June 2022. We would plan to have it ready around summer this year. Regarding the chances, please have a look to the comment before.

@danielskatz
Copy link
Collaborator

ok, now I see the link

@ExtremOPS
Copy link
Author

@danielskatz @arfon Did you had a chance to have a glimpse at the posted link and think about the planned additions? And if so, could you judge if our updates and software are feasible for JOSS? We would really like to publish with you and start the publication process. If you have any further questions, do not hesitate to contact me.
Thank you in advance!

@danielskatz
Copy link
Collaborator

To me, it seems like it is worth submitting - this might lead to a scope review by the editors, which would be the best way to be sure that the update is sufficient.

@ExtremOPS
Copy link
Author

@danielskatz thank you for the fast reply. We will finish on our side the mentioned steps and start preparing a publication according to Submitting a paper to JOSS. I am looking forward to the transparent process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants