Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: adapol: Adaptive pole-fitting for Matsubara functions #7692

Open
editorialbot opened this issue Jan 17, 2025 · 18 comments
Open
Labels
pre-review query-scope Submissions of uncertain scope for JOSS Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @Hertz4 (Zhen)
Repository: https://github.com/flatironinstitute/adapol
Branch with paper.md (empty if default branch): joss
Version: v0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7f6e8f43201ca659460ad7a459985d61"><img src="https://joss.theoj.org/papers/7f6e8f43201ca659460ad7a459985d61/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7f6e8f43201ca659460ad7a459985d61/status.svg)](https://joss.theoj.org/papers/7f6e8f43201ca659460ad7a459985d61)

Author instructions

Thanks for submitting your paper to JOSS @Hertz4. Currently, there isn't a JOSS editor assigned to your paper.

@Hertz4 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jan 17, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/PhysRevB.107.075151 is OK
- 10.1016/j.cpc.2015.04.023 is OK
- 10.1103/PhysRevB.101.035143 is OK
- 10.1103/PhysRevX.14.031034 is OK
- 10.1137/16M1106122 is OK
- 10.1103/PhysRevB.105.235115 is OK
- 10.1103/PhysRevLett.126.056402 is OK
- 10.1103/PhysRevB.104.165111 is OK
- 10.1103/PhysRevB.93.075104 is OK
- 10.1103/RevModPhys.68.13 is OK
- 10.1103/PhysRevB.103.045120 is OK
- 10.1016/j.jcp.2022.111549 is OK
- 10.1103/PhysRevB.110.035154 is OK
- 10.1103/PhysRevB.110.235131 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: adapol: Adaptive Pole Fitting for Quantum Many-Bod...
- No DOI given, and none found for title: adapol: Adaptive Pole Fitting for Quantum Many-Bod...
- No DOI given, and none found for title: Efficient evaluation of bold strong coupling diagr...

❌ MISSING DOIs

- 10.1103/physrevb.110.075158 may be a valid DOI for title: Feynman diagrammatics based on discrete pole repre...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.02 s (1372.0 files/s, 154939.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           8            211            214            650
TeX                              1              9              0            208
reStructuredText                 7            249            334            164
Jupyter Notebook                 3              0            640            159
YAML                             3             12              6            106
Markdown                         2             24              0             83
TOML                             1              3              0             32
DOS Batch                        1              8              1             26
make                             1              4              7              9
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            28            520           1202           1440
-------------------------------------------------------------------------------

Commit count by author:

   139	Hertz4
    12	Nils Wentzell
     6	Zhen Huang
     3	Jason Kaye
     1	Chia-Nan Yeh
     1	cnyeh

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 694

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HofstadterTools: A Python package for analyzing the Hofstadter model
Submitting author: @bartandrews
Handling editor: @RMeli (Active)
Reviewers: @AlexBuccheri, @katherineding
Similarity score: 0.6910

solid_dmft: gray-boxing DFT+DMFT materials simulations with TRIQS
Submitting author: @the-hampel
Handling editor: @rkurchin (Active)
Reviewers: @amandadumi, @shivupa
Similarity score: 0.6858

SphericalScattering: A Julia Package for Electromagnetic Scattering from Spherical Objects
Submitting author: @HoBeZwe
Handling editor: @pdebuyl (Active)
Reviewers: @iliarasskazov, @berquist
Similarity score: 0.6817

QAOA.jl: Toolkit for the Quantum and Mean-Field Approximate Optimization Algorithms
Submitting author: @timbode
Handling editor: @danielskatz (Active)
Reviewers: @babreu-ncsa, @pkairys, @Abinashbunty
Similarity score: 0.6809

Qiskit Dynamics: A Python package for simulating the time dynamics of quantum systems
Submitting author: @DanPuzzuoli
Handling editor: @danielskatz (Active)
Reviewers: @babreu-ncsa, @goerz, @hodgestar
Similarity score: 0.6788

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Jan 17, 2025

@editorialbot query scope

@Hertz4 – due to the relatively small size of this code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week. If you want to fix the DOIs (noting that @editorialbot's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@editorialbot generate pdf
@editorialbot check references

Finally, it looks like this submission is missing an open source license. Please add one.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 17, 2025
@Hertz4
Copy link

Hertz4 commented Jan 17, 2025

@editorialbot generate pdf

@Hertz4
Copy link

Hertz4 commented Jan 17, 2025

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1103/PhysRevB.107.075151 is OK
- 10.1016/j.cpc.2015.04.023 is OK
- 10.1103/PhysRevB.101.035143 is OK
- 10.1103/PhysRevX.14.031034 is OK
- 10.1137/16M1106122 is OK
- 10.1103/PhysRevB.105.235115 is OK
- 10.1103/PhysRevLett.126.056402 is OK
- 10.1103/PhysRevB.104.165111 is OK
- 10.1103/PhysRevB.93.075104 is OK
- 10.1103/RevModPhys.68.13 is OK
- 10.1103/PhysRevB.103.045120 is OK
- 10.1016/j.jcp.2022.111549 is OK
- 10.1103/PhysRevB.110.035154 is OK
- 10.1103/PhysRevB.110.235131 is OK
- 10.48550/arXiv.2407.01389 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: adapol: Adaptive Pole Fitting for Quantum Many-Bod...
- No DOI given, and none found for title: adapol: Adaptive Pole Fitting for Quantum Many-Bod...
- No DOI given, and none found for title: Efficient evaluation of bold strong coupling diagr...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HofstadterTools: A Python package for analyzing the Hofstadter model
Submitting author: @bartandrews
Handling editor: @RMeli (Active)
Reviewers: @AlexBuccheri, @katherineding
Similarity score: 0.6931

solid_dmft: gray-boxing DFT+DMFT materials simulations with TRIQS
Submitting author: @the-hampel
Handling editor: @rkurchin (Active)
Reviewers: @amandadumi, @shivupa
Similarity score: 0.6873

SphericalScattering: A Julia Package for Electromagnetic Scattering from Spherical Objects
Submitting author: @HoBeZwe
Handling editor: @pdebuyl (Active)
Reviewers: @iliarasskazov, @berquist
Similarity score: 0.6847

Qiskit Dynamics: A Python package for simulating the time dynamics of quantum systems
Submitting author: @DanPuzzuoli
Handling editor: @danielskatz (Active)
Reviewers: @babreu-ncsa, @goerz, @hodgestar
Similarity score: 0.6805

ShakeNBreak: Navigating the defect configurational landscape
Submitting author: @ireaml
Handling editor: @rkurchin (Active)
Reviewers: @obaica, @mkhorton
Similarity score: 0.6801

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Hertz4
Copy link

Hertz4 commented Jan 17, 2025

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.02 s (1327.0 files/s, 149898.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           8            211            214            650
TeX                              1              9              0            209
reStructuredText                 7            249            334            164
Jupyter Notebook                 3              0            640            159
YAML                             3             12              6            106
Markdown                         2             24              0             83
TOML                             1              3              0             32
DOS Batch                        1              8              1             26
make                             1              4              7              9
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            28            520           1202           1441
-------------------------------------------------------------------------------

Commit count by author:

   140	Hertz4
    12	Nils Wentzell
     7	Zhen Huang
     3	Jason Kaye
     1	Chia-Nan Yeh
     1	cnyeh

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 694

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

3 participants