Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: FTorch: a library for coupling PyTorch models to Fortran #7573

Closed
editorialbot opened this issue Dec 6, 2024 · 24 comments
Closed
Assignees
Labels
C++ Fortran pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 6, 2024

Submitting author: @jatkinson1000 (Jack Atkinson)
Repository: https://github.com/Cambridge-ICCS/FTorch
Branch with paper.md (empty if default branch): JOSS
Version: v1.0.0
Editor: @matthewfeickert
Reviewers: @parikshitbajpai, @timothyas
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/171ec3ec7deaa00418caab47afdc33ef"><img src="https://joss.theoj.org/papers/171ec3ec7deaa00418caab47afdc33ef/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/171ec3ec7deaa00418caab47afdc33ef/status.svg)](https://joss.theoj.org/papers/171ec3ec7deaa00418caab47afdc33ef)

Author instructions

Thanks for submitting your paper to JOSS @jatkinson1000. Currently, there isn't a JOSS editor assigned to your paper.

@jatkinson1000 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 6, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/s11831-022-09795-8 is OK
- 10.1029/2022GL098174 is OK
- 10.1098/rsta.2020.0093 is OK
- 10.1109/MCSE.2022.3159862 is OK
- 10.1103/RevModPhys.91.045002 is OK
- 10.1029/2024MS004292 is OK
- 10.48550/arXiv.2011.03081 is OK
- 10.1016/j.jocs.2022.101707 is OK
- 10.1029/2024MS004398 is OK
- 10.1145/3323057.3323059 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fortitude
- No DOI given, and none found for title: fypp
- No DOI given, and none found for title: clang-format
- No DOI given, and none found for title: clang-tidy
- No DOI given, and none found for title: Pytorch: An imperative style, high-performance dee...
- No DOI given, and none found for title: MiMA Machine Learning
- No DOI given, and none found for title: CAM-ML
- No DOI given, and none found for title: DataWave CAM-GW
- No DOI given, and none found for title: forpy
- No DOI given, and none found for title: pytorch-fortran
- No DOI given, and none found for title: TorchFort

❌ MISSING DOIs

- 10.1093/gmo/9781561592630.article.24101 may be a valid DOI for title: ruff

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1806.5 files/s, 238293.5 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Fortran 90                       11            811            421           2833
Markdown                         24            586              0           1963
Python                           18            357            766            788
C++                               2             29             32            320
CMake                             9             75             82            275
YAML                              5             42             52            240
TeX                               1             21              0            189
C/C++ Header                      1             20            103             54
Bourne Again Shell                1              8             14             47
C                                 1              9              4             47
make                              2             16              8             26
TOML                              2              5             11             12
Bourne Shell                      1              3              9             11
--------------------------------------------------------------------------------
SUM:                             78           1982           1502           6805
--------------------------------------------------------------------------------

Commit count by author:

    69	jatkinson1000
    43	Jack Atkinson
    41	Joe Wallwork
    37	ElliottKasoar
    17	Dominic Orchard
    15	Athena Elafrou
    13	melt
     4	Simon Clifford
     2	SimonClifford
     1	helgehr
     1	mondus
     1	tommelt
     1	vopikamm

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1767

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

h5fortran: object-oriented polymorphic Fortran interface for HDF5 file IO
Submitting author: @scivision
Handling editor: @pdebuyl (Active)
Reviewers: @milancurcic, @bast
Similarity score: 0.6960

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.6954

Pyccel: a Python-to-X transpiler for scientific high-performance computing
Submitting author: @yguclu
Handling editor: @danielskatz (Active)
Reviewers: @aholmes, @IgorBaratta, @boegel
Similarity score: 0.6851

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.6833

GMP-Featurizer: A parallelized Python package for efficiently computing the Gaussian Multipole features of atomic systems
Submitting author: @RayLei-TRI
Handling editor: @rkurchin (Active)
Reviewers: @isdanni, @bdice, @yw-fang
Similarity score: 0.6736

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @jatkinson1000 - Thanks for your submission. I'll look for an editor next.

@danielskatz
Copy link

danielskatz commented Dec 6, 2024

👋 @matthewfeickert - Would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @matthewfeickert as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jatkinson1000
Copy link

jatkinson1000 commented Dec 6, 2024

We can suggest the following as possible reviewers:

  • timothyas
  • berrli
  • ewu63
  • milancurcic
  • tvwenger
  • gomezzz
  • RMeli
  • pankajkmishra

If you need further suggestions please let me know and I will look for more.

@matthewfeickert
Copy link
Member

Thanks @danielskatz.

@jatkinson1000 @danielskatz I would be happy to be the editor for this, but given some hard deadlines for professional things fast approaching I might not be able to start on the process in earnest until late next week. If you would greatly prefer for someone to start the process ASAP though I think I'll need to decline.

@danielskatz
Copy link

Late next week will be fine. Given our editor load, I don't see another way of this happening sooner.

@danielskatz
Copy link

@editorialbot assign @matthewfeickert as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @matthewfeickert is now the editor

@matthewfeickert
Copy link
Member

@editorialbot add @parikshitbajpai as reviewer

@editorialbot
Copy link
Collaborator Author

@parikshitbajpai added to the reviewers list!

@matthewfeickert
Copy link
Member

Note: @parikshitbajpai will be unavailable to start the review until the second week of January, 2025, so while we'll hopefully find two more reviewers to give some buffer I'll make sure to send reminders in January once people are back from end of year holidays.

@matthewfeickert
Copy link
Member

@editorialbot add @timothyas as reviewer

@editorialbot
Copy link
Collaborator Author

@timothyas added to the reviewers list!

@matthewfeickert
Copy link
Member

We now have the minimum two reviewers required, so I'll go ahead and start the review. Additional reviewers are very welcome so if other potential reviewers I contacted would be interested in helping I can add you to the review after it has started.

@matthewfeickert
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Fortran pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

4 participants