Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: rdata: A Python library for R datasets #7540

Closed
editorialbot opened this issue Dec 1, 2024 · 20 comments
Closed

[REVIEW]: rdata: A Python library for R datasets #7540

editorialbot opened this issue Dec 1, 2024 · 20 comments
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 8 (MISC) Miscellaneous

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 1, 2024

Submitting author: @vnmabus (Carlos Ramos-Carreño)
Repository: https://github.com/vnmabus/rdata
Branch with paper.md (empty if default branch): feature/joss_paper
Version: 0.11.0
Editor: @arfon
Reviewers: @has2k1, @rich-iannone
Archive: 10.5281/zenodo.10776842

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e"><img src="https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e/status.svg)](https://joss.theoj.org/papers/62145d2bd727d628ab413174d428984e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@has2k1 & @rich-iannone, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@has2k1, please create your checklist typing: @editorialbot generate my checklist

@rich-iannone, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1191.7 files/s, 147116.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26           1011           1017           3125
Markdown                         6             91              0            275
reStructuredText                 8            150            204            265
YAML                             8             33             23            252
TOML                             1             18              0            135
TeX                              1              7              0             91
DOS Batch                        1              8              1             27
JSON                             2              1              0             22
SVG                              1              0              0             14
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            55           1323           1251           4216
-------------------------------------------------------------------------------

Commit count by author:

   160	Tuomas Rossi
   141	VNMabus
    53	vnmabus
    22	Carlos Ramos Carreño

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6383047 is OK
- 10.5281/zenodo.7110169 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.3509134 is OK
- 10.18637/jss.v109.i02 is OK
- 10.1371/journal.pcbi.1011914 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rpy2: R in Python

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1475

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Dec 1, 2024

@editorialbot set 10.5281/zenodo.10776842 as archive

@editorialbot
Copy link
Collaborator Author

Done! archive is now 10.5281/zenodo.10776842

@arfon
Copy link
Member

arfon commented Dec 1, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6383047 is OK
- 10.5281/zenodo.7110169 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.3509134 is OK
- 10.18637/jss.v109.i02 is OK
- 10.1371/journal.pcbi.1011914 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Rpy2: R in Python

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/misc-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6198, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Dec 1, 2024
@arfon
Copy link
Member

arfon commented Dec 1, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Ramos-Carreño
  given-names: Carlos
  orcid: "https://orcid.org/0000-0003-2566-7058"
- family-names: Rossi
  given-names: Tuomas
  orcid: "https://orcid.org/0000-0002-8713-4559"
doi: 10.5281/zenodo.10776842
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Ramos-Carreño
    given-names: Carlos
    orcid: "https://orcid.org/0000-0003-2566-7058"
  - family-names: Rossi
    given-names: Tuomas
    orcid: "https://orcid.org/0000-0002-8713-4559"
  date-published: 2024-12-01
  doi: 10.21105/joss.07540
  issn: 2475-9066
  issue: 104
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 7540
  title: "rdata: A Python library for R datasets"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.07540"
  volume: 9
title: "rdata: A Python library for R datasets"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.07540 joss-papers#6199
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.07540
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Dec 1, 2024
@arfon
Copy link
Member

arfon commented Dec 1, 2024

@has2k1, @rich-iannone – many thanks for your reviews at pyOpenSci! JOSS and pyOpenSci relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@vnmabus – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Dec 1, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following

code snippets

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.07540/status.svg)](https://doi.org/10.21105/joss.07540)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.07540">
  <img src="https://joss.theoj.org/papers/10.21105/joss.07540/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.07540/status.svg
   :target: https://doi.org/10.21105/joss.07540

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 8 (MISC) Miscellaneous
Projects
None yet
Development

No branches or pull requests

2 participants