Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: NumbaCS: A fast Python package for coherent structure analysis #7347

Open
editorialbot opened this issue Oct 13, 2024 · 33 comments
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 13, 2024

Submitting author: @alb3rtjarvis (Albert Jarvis)
Repository: https://github.com/alb3rtjarvis/numbacs
Branch with paper.md (empty if default branch): paper
Version: 0.1.1
Editor: @drvinceknight
Reviewers: @janfb
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f99d7057f5812b25c95807fecdbfa5d9"><img src="https://joss.theoj.org/papers/f99d7057f5812b25c95807fecdbfa5d9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f99d7057f5812b25c95807fecdbfa5d9/status.svg)](https://joss.theoj.org/papers/f99d7057f5812b25c95807fecdbfa5d9)

Author instructions

Thanks for submitting your paper to JOSS @alb3rtjarvis. Currently, there isn't a JOSS editor assigned to your paper.

@alb3rtjarvis if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Oct 13, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.56 s (271.7 files/s, 560697.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            25              0              0          22576
Python                          41           1730           3303           4818
reStructuredText                46           3733         268404           1268
TeX                              2             63              0            723
SVG                              2              2              2            710
Markdown                         4            141              0            528
Jupyter Notebook                25              0           3397             61
TOML                             1              6              0             47
YAML                             2              8              6             28
DOS Batch                        1              8              1             26
make                             1              4              7              9
CSS                              1              0              0              7
-------------------------------------------------------------------------------
SUM:                           151           5695         275120          30801
-------------------------------------------------------------------------------

Commit count by author:

   121	alb3rtjarvis

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1592

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Mozilla Public License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6779400 is OK
- 10.3390/en16124800 is OK
- 10.1016/j.jocs.2014.12.002 is OK
- 10.1145/2833157.2833162 is OK
- 10.1016/j.physd.2005.10.007 is OK
- 10.1016/S0167-2789(98)00091-8 is OK
- 10.1016/S0167-2789(00)00199-8 is OK
- 10.1016/j.physd.2022.133580 is OK
- 10.1016/j.physd.2010.11.010 is OK
- 10.1063/1.3690153 is OK
- 10.1063/1.1477449 is OK
- 10.1007/978-3-642-23175-9_15 is OK
- 10.1016/j.physd.2012.05.008 is OK
- 10.1063/1.4951720 is OK
- 10.1007/s11071-020-05713-4 is OK
- 10.1109/34.659930 is OK
- 10.1103/PhysRevLett.98.144502 is OK
- 10.1002/nme.3101 is OK
- 10.1017/jfm.2013.391 is OK
- 10.1098/rspa.2016.0807 is OK
- 10.1017/jfm.2016.151 is OK
- 10.1063/1.3270044 is OK
- 10.3390/fluids6010016 is OK
- 10.1016/j.atmosenv.2024.120638 is OK
- 10.5067/QBZ6MG944HW0 is OK
- 10.1175/JCLI-D-16-0758.1 is OK
- 10.1002/eap.2806 is OK
- 10.1029/2021JD035000 is OK
- 10.1175/JAS-D-17-0052.1 is OK
- 10.3390/atmos11020168 is OK
- 10.1007/s11784-010-0028-6 is OK
- 10.5194/acp-12-5483-2012 is OK
- 10.1002/2017JC013390 is OK
- 10.1029/2023JD039773 is OK
- 10.1063/PT.3.1886 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Lagrangian
- No DOI given, and none found for title: Dynlab
- No DOI given, and none found for title: Transport and Separatrices in Time-Dependent Flows
- No DOI given, and none found for title: CoherentStructures.jl
- No DOI given, and none found for title: LCS MATLAB Kit
- No DOI given, and none found for title: numbalsoda
- No DOI given, and none found for title: interpolation.py
- No DOI given, and none found for title: Transport Barriers and Coherent Structures in Flow...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PyMPDATA v1: Numba-accelerated implementation of MPDATA with examples in Python, Julia and Matlab
Submitting author: @slayoo
Handling editor: @arfon (Active)
Reviewers: @Chiil, @wdeconinck
Similarity score: 0.6880

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia
Submitting author: @lluisjofre
Handling editor: @diehlpk (Active)
Reviewers: @ctdegroot, @thomasgillis
Similarity score: 0.6878

LDDS: Python package for computing and visualizing Lagrangian Descriptors for Dynamical Systems
Submitting author: @Shibabrat
Handling editor: @richardjgowers (Retired)
Reviewers: @nicoguaro, @jmbr
Similarity score: 0.6808

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.6666

FlowSieve: A Coarse-Graining Utility for Geophysical Flows on the Sphere
Submitting author: @bastorer
Handling editor: @kthyng (Active)
Reviewers: @NoraLoose, @ashwinvis
Similarity score: 0.6662

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@alb3rtjarvis - sorry for the delay - I've been trying to figure out which track this fits in, as it crosses some different areas, and I think for that reason, it's probably best in the computer science, information science, and math track where it is now. So I'll try to find an editor next, which might take a little bit, as most editors are at their limits currently.

@danielskatz
Copy link

👋 @jedbrown - Would you want to edit this submission? I think it's a good fit for you, but I'm unsure of your availability for another submission at this point.

@danielskatz
Copy link

@editorialbot invite @jedbrown as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@alb3rtjarvis
Copy link

@danielskatz No worries, I appreciate the help and understand it is a busy time.

@alb3rtjarvis
Copy link

As for suggested reviewers once an editor is assigned - mbudisic may be a good fit.

@danielskatz
Copy link

@alb3rtjarvis - while normally the editor would ask this, I will since you've already given us one suggestion:

Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

@danielskatz
Copy link

👋 @drvinceknight - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @drvinceknight as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@alb3rtjarvis
Copy link

Potential reviewers:

  • mbudisic
  • Shibabrat
  • jmbr
  • dawbarton
  • yueyanglu

@drvinceknight
Copy link

I'll be the editor for this paper. Thanks @alb3rtjarvis for the suggested reviewers.

@danielskatz
Copy link

@editorialbot assign @drvinceknight as editor

Thanks @drvinceknight!

@editorialbot
Copy link
Collaborator Author

Assigned! @drvinceknight is now the editor

@alb3rtjarvis
Copy link

No problem @drvinceknight and thanks for being the editor!

@drvinceknight
Copy link

@mbudisic @Shibabrat @jmbr I'm pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: “NumbaCS: A fast Python package for coherent structure analysis”. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

@jmbr
Copy link

jmbr commented Nov 12, 2024

@drvinceknight Sorry, I can't review at the moment.

@drvinceknight
Copy link

Thanks for letting me know @jmbr

@alb3rtjarvis
Copy link

@drvinceknight I recently looked at the JOSS COI policy and realized there may be a COI with Shibabrat as he was previously advised by the second author of this paper. I apologize for overlooking this. Please let me know if you need me to recommend another reviewer.

@drvinceknight
Copy link

Thanks for your patience @alb3rtjarvis, let's see how things go but I should be able to find reviewers :)

@drvinceknight
Copy link

@dawbarton @yueyanglu I'm pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: “NumbaCS: A fast Python package for coherent structure analysis”. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

@drvinceknight
Copy link

@janfb @ysimillides @slayoo I'm pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: “NumbaCS: A fast Python package for coherent structure analysis”. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

@janfb
Copy link

janfb commented Feb 4, 2025

hi @drvinceknight thanks for inviting me here. Yes, I would be up for reviewing this.

@drvinceknight
Copy link

Thank you!

@drvinceknight
Copy link

@editorialbot add @janfb as reviewer

@editorialbot
Copy link
Collaborator Author

@janfb added to the reviewers list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

6 participants