Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pybeepop+: A Python wrapper for the BeePop+ honey bee colony model #7335

Closed
editorialbot opened this issue Oct 9, 2024 · 15 comments
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @JeffreyMinucci (Jeffrey Minucci)
Repository: https://github.com/USEPA/pybeepop
Branch with paper.md (empty if default branch):
Version: v0.1.1
Editor: Pending
Reviewers: Pending
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f012d5fd9b575eecf46b9ba296cf39cb"><img src="https://joss.theoj.org/papers/f012d5fd9b575eecf46b9ba296cf39cb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f012d5fd9b575eecf46b9ba296cf39cb/status.svg)](https://joss.theoj.org/papers/f012d5fd9b575eecf46b9ba296cf39cb)

Author instructions

Thanks for submitting your paper to JOSS @JeffreyMinucci. Currently, there isn't a JOSS editor assigned to your paper.

@JeffreyMinucci if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Oct 9, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1060.5 files/s, 114711.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5             74            129            404
CSV                              2              0              0            226
YAML                             6             29             25            220
Markdown                         2             73              0            177
TeX                              1             13              0            149
TOML                             1              6              0             62
Jupyter Notebook                 1              0            329             31
-------------------------------------------------------------------------------
SUM:                            18            195            483           1269
-------------------------------------------------------------------------------

Commit count by author:

   105	JeffreyMinucci
    52	Jeff Minucci

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.6856426 is OK
- 10.1002/ece3.1293 is OK
- 10.1016/j.tim.2011.09.003 is OK
- 10.5281/zenodo.3509134 is OK
- 10.1098/rspb.2020.0922 is OK
- 10.1126/science.aaa1190 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Dask: Library for dynamic task scheduling
- No DOI given, and none found for title: The population dynamics of varroa mites in honey b...
- No DOI given, and none found for title: Simulating the effects of pesticides on honey bee ...
- No DOI given, and none found for title: BEEPOP+

❌ MISSING DOIs

- 10.1126/science.1255957 may be a valid DOI for title: Bee declines driven by combined stress from parasi...
- 10.1093/bioinformatics/bty361 may be a valid DOI for title: pyABC: distributed, likelihood-free inference
- 10.1016/j.ecolmodel.2018.02.010 may be a valid DOI for title: Sensitivity analyses for simulating pesticide impa...
- 10.1002/eap.2442 may be a valid DOI for title: Inferring pesticide toxicity to honey bees from a ...
- 10.1111/gcb.17219 may be a valid DOI for title: Advances and knowledge gaps on climate change impa...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 720

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@arfon
Copy link
Member

arfon commented Oct 9, 2024

@JeffreyMinucci – due to the relatively small size of this code and the fact it looks like an API/library wrapper, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. We should get back to you sometime next week. If you want to fix the DOIs (noting that @editorialbot's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@editorialbot generate pdf
@editorialbot check references

@arfon
Copy link
Member

arfon commented Oct 9, 2024

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Oct 9, 2024
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

pyPhenology: A python framework for plant phenology modelling
Submitting author: @sdtaylor
Handling editor: @pjotrp (Retired)
Reviewers: @harmn, @Chilipp
Similarity score: 0.6968

epipack: An infectious disease modeling package for Python
Submitting author: @benmaier
Handling editor: @fboehm (Active)
Reviewers: @chrisvoncsefalvay, @esteinig
Similarity score: 0.6855

ewstools: A Python package for early warning signals of bifurcations in time series data
Submitting author: @ThomasMBury
Handling editor: @osorensen (Active)
Reviewers: @mhu48, @mikesha2, @ranzhengcode
Similarity score: 0.6826

epyc: Computational experiment management in Python
Submitting author: @simoninirelland
Handling editor: @ajstewartlang (Active)
Reviewers: @zbeekman, @lorenzo-rovigatti, @amritagos
Similarity score: 0.6791

neotoma2: An R package to access data from the Neotoma Paleoecology Database
Submitting author: @SimonGoring
Handling editor: @crvernon (Active)
Reviewers: @kanishkan91, @mhesselbarth
Similarity score: 0.6773

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Oct 28, 2024

@JeffreyMinucci Thanks again for your submission. Unfortunately the JOSS editorial board has determined that it is too small in scope to pass for substantial scholarly effort. However, note that if you were to expand the functionality of your library quite a bit over time, you could consider submitting to JOSS again in the future.

Alternatively, there are other ways to publish your software now we can suggest, notes here: https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages.

Thanks for your interest in JOSS.

@kthyng
Copy link

kthyng commented Oct 28, 2024

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

@JeffreyMinucci
Copy link

JeffreyMinucci commented Oct 28, 2024

@kthyng @arfon I thank the editorial board for their review. Respectfully, am I able to appeal this decision?

I would like to provide additional rationale that this work represents significant scholarly effort:

  • This software makes the BeePop+ model developed by the US Environmental Protection Agency and US Department of Agriculture widely available and accessible to the scientific community, government regulators and the public for the first time. The pybeepop+ package will be the primary way that US EPA scientists install and interact with the underlying model to support regulation of pesticides and protection of pollinators. Therefore, it is of great public interest that the software and accompanying paper receive rigorous peer review.
  • The software (in an early version) has already been used and cited in two scientific publications from the US EPA, with at least one other in prep and several more studies on the horizon: paper 1 paper 2. This demonstrates that it has substantial utility to advance research and shape regulatory decisions.
  • The software is more than a 'thin API client' or similar because it includes features not available in the underlying C++ interface: multiple output formats (DataFrame, JSON), validation of parameters, informative error messages, API documentation, tests, example notebooks and automated installation of BeePop+ for a wider range of systems via Python wheels and pre-compilation of BeePop+ on many platforms (implemented via GitHub CIs).
  • The software is over 1000 lines of code with CSV files removed, which is the number cited on the Submitting a paper to JOSS article as the cutoff for flagging.

Thank you for your further consideration.

@kthyng
Copy link

kthyng commented Oct 30, 2024

@JeffreyMinucci I agree with you on many of your points, them feeding into the reason JOSS exists and that we put our time into it. However, we also have to have a lower bound for enough effort and it gets into the nitty gritty at some point. We count the Python lines of code but not the other bits as being related to docs, workflows, etc, rather than fundamental code. Therefore we see your package as 404 LOC, not 1000. We also look at how long a project has been under development and want a minimum of 3 months, which this is just over. All of this pushes in the same direction. However, I'd still like to see it resubmitted if there is more, useful functionality that would make sense for you or your team to add over time. Thanks again.

github.com/AlDanial/cloc v 1.90  T=0.02 s (1060.5 files/s, 114711.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5             74            129            404
CSV                              2              0              0            226
YAML                             6             29             25            220
Markdown                         2             73              0            177
TeX                              1             13              0            149
TOML                             1              6              0             62
Jupyter Notebook                 1              0            329             31
-------------------------------------------------------------------------------
SUM:                            18            195            483           1269
-------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS rejected Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

4 participants