Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PestoSeis: A Python package for 2D wave physics and educational seismology #7040

Closed
editorialbot opened this issue Jul 26, 2024 · 24 comments
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 26, 2024

Submitting author: @inverseproblem (Andrea Zunino)
Repository: https://gitlab.com/anzun/PestoSeis
Branch with paper.md (empty if default branch): main
Version: v0.3.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/82936c8abb25e8ce35f5046ced1bd0ec"><img src="https://joss.theoj.org/papers/82936c8abb25e8ce35f5046ced1bd0ec/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/82936c8abb25e8ce35f5046ced1bd0ec/status.svg)](https://joss.theoj.org/papers/82936c8abb25e8ce35f5046ced1bd0ec)

Author instructions

Thanks for submitting your paper to JOSS @inverseproblem. Currently, there isn't a JOSS editor assigned to your paper.

@inverseproblem if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Jul 26, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (742.9 files/s, 83208.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              2             12              0            189
Markdown                         2             37              0            145
Jupyter Notebook                 1              0            282             98
YAML                             1              2              0             18
Bourne Shell                     1              0              0              1
-------------------------------------------------------------------------------
SUM:                             7             51            282            451
-------------------------------------------------------------------------------

Commit count by author:

    12	Ines Elisa Ulrich
    10	Patrick Marty
     8	Andrea Zunino
     3	inverseproblem

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1470

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@kthyng
Copy link

kthyng commented Jul 26, 2024

@inverseproblem Can you take a look at the paper compilation error and try to fix it?

@inverseproblem
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SeismicMesh: Triangular meshing for seismology
Submitting author: @krober10nd
Handling editor: @meg-simula (Retired)
Reviewers: @nschloe, @jorgensd
Similarity score: 0.7100

elwaspatid: A Python package to compute space-time diagrams for the propagation of elastic waves in 1D rods
Submitting author: @dbrizard
Handling editor: @diehlpk (Active)
Reviewers: @obsmax, @MargeritPierre
Similarity score: 0.7086

pyprop8: A lightweight code to simulate seismic observables in a layered half-space
Submitting author: @valentineap
Handling editor: @leouieda (Retired)
Reviewers: @hemmelig, @hfmark
Similarity score: 0.6972

APECSS: A software library for cavitation bubble dynamics and acoustic emissions
Submitting author: @fabiandenner
Handling editor: @kyleniemeyer (Active)
Reviewers: @jmansour, @svchb
Similarity score: 0.6942

rsudp: A Python package for real-time seismic monitoring with Raspberry Shake instruments
Submitting author: @iannesbitt
Handling editor: @jedbrown (Active)
Reviewers: @fwalter, @calum-chamberlain
Similarity score: 0.6798

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@inverseproblem
Copy link

@kthyng I believe the error should now be fixed. Thanks!

@kthyng
Copy link

kthyng commented Aug 9, 2024

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@kthyng
Copy link

kthyng commented Aug 9, 2024

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (427.4 files/s, 345817.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              3              2              2          10306
Python                          21           1414           2598           3111
Jupyter Notebook                 9              0          19124            564
reStructuredText                10            246            181            341
YAML                             1              5              0             32
DOS Batch                        1              8              1             26
Markdown                         1             21              0             20
make                             1              4              6             13
-------------------------------------------------------------------------------
SUM:                            47           1700          21912          14413
-------------------------------------------------------------------------------

Commit count by author:

    52	Andrea Zunino
    50	Ines Elisa Ulrich
    38	Patrick Marty
    15	inverseproblem
     9	Andrea Z
     1	anzun
     1	inesulrich

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Failed to find a paper file in https://gitlab.com/anzun/PestoSeis (branch: main)

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@kthyng
Copy link

kthyng commented Aug 9, 2024

@inverseproblem I like that this code works to be clear and easy to understand, but it does state "do not use this code for research." (https://anzun.gitlab.io/PestoSeis/). This is a problem for JOSS since our mission is to publish research code. Maybe your package would be a better fit for JOSE? https://jose.theoj.org/

@kthyng
Copy link

kthyng commented Aug 16, 2024

@inverseproblem Any thoughts on my comment ⬆️ ?

@inverseproblem
Copy link

@kthyng, thanks, we think this is indeed a good suggestion, we didn't realise there was that possibility earlier. So, how should I proceed in order to withdraw the submission here and switch to JOSE?

@kthyng
Copy link

kthyng commented Aug 23, 2024

If you tell me to go ahead, I will run the command to withdraw your submission, then you go to https://jose.theoj.org/ and go through the process there to submit.

@inverseproblem
Copy link

Ok, so, please go ahead with the withdrawal. Thank you!

@kthyng
Copy link

kthyng commented Aug 27, 2024

@editorialbot withdraw

@editorialbot
Copy link
Collaborator Author

Paper withdrawn.

@kthyng
Copy link

kthyng commented Aug 27, 2024

@inverseproblem Good luck with your submission with JOSE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants