Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: xesn: Echo state networks powered by xarray and dask #6933

Closed
editorialbot opened this issue Jun 26, 2024 · 48 comments
Closed
Assignees
Labels
pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 26, 2024

Submitting author: @timothyas (Timothy Smith)
Repository: https://github.com/timothyas/xesn
Branch with paper.md (empty if default branch):
Version: v0.1.4
Editor: @sneakers-the-rat
Reviewers: @Arcomano1234, @wiljnich
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/84a7fddace8425c95603b4f690a69896"><img src="https://joss.theoj.org/papers/84a7fddace8425c95603b4f690a69896/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/84a7fddace8425c95603b4f690a69896/status.svg)](https://joss.theoj.org/papers/84a7fddace8425c95603b4f690a69896)

Author instructions

Thanks for submitting your paper to JOSS @timothyas. Currently, there isn't a JOSS editor assigned to your paper.

@timothyas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Jun 26, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (1049.2 files/s, 267278.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          24           1054            726           2964
TeX                              1            163              0           1699
Jupyter Notebook                 6              0           6019            840
Markdown                         3            107              0            545
YAML                            12             50             66            476
reStructuredText                 9            157            143            403
TOML                             2              4              0             34
DOS Batch                        1              8              1             26
JSON                             1              1              0             16
make                             1              5              7             11
Bourne Shell                     1              2              8              4
-------------------------------------------------------------------------------
SUM:                            61           1551           6970           7018
-------------------------------------------------------------------------------

Commit count by author:

    39	Timothy Smith
    21	timothyas

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 3240

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@crvernon
Copy link

@editorialbot invite @jromanowska as editor

👋 @jromanowska - since we are wrapping up one of your other submissions, do you think you could take this one on?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

👋 @timothyas -There are a few things that you can take care of until I get a topic editor assigned to your submission:

  • fix your paper.md file header. I believe you have an extra tab in front of your ORCID specifications. Once fixed, we should be able to compile from here.
  • Please bring the word count of your paper to around a max of 1000 words. You can reference your documentation if needed from the paper.
  • I don't see a paper.bib file with your bibliography present in your repo

Thanks!

@timothyas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

STITCHES: a Python package to amalgamate existing Earth system model output into new scenario realizations
Submitting author: @abigailsnyder
Handling editor: @observingClouds (Active)
Reviewers: @znicholls, @Zeitsperre
Similarity score: 0.7081

xeofs: Comprehensive EOF analysis in Python with xarray
Submitting author: @nicrie
Handling editor: @samhforbes (Active)
Reviewers: @DamienIrving, @malmans2
Similarity score: 0.7024

pyCSEP: A Python Toolkit For Earthquake Forecast Developers
Submitting author: @wsavran
Handling editor: @kbarnhart (Retired)
Reviewers: @nvanderelst, @mbarall
Similarity score: 0.7000

epyc: Computational experiment management in Python
Submitting author: @simoninirelland
Handling editor: @ajstewartlang (Active)
Reviewers: @zbeekman, @lorenzo-rovigatti, @amritagos
Similarity score: 0.6965

brains-py, A framework to support research on energy-efficient unconventional hardware for machine learning
Submitting author: @ualegre
Handling editor: @arfon (Active)
Reviewers: @wob86, @sisco0
Similarity score: 0.6939

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@timothyas
Copy link

@crvernon thank you for this!

  • I think I fixed the tabbing issue in the paper.md header, it looks like editorialbot was able to compile the pdf.
  • I am using a bibliography file located within the docs directory of the repo (at docs/references.bib). Will this work, or does it have to be paper.bib in the main directory of the repo?
  • I will work on the wordcount, I didn't realize the word limit was strict.

@jromanowska
Copy link

Hi, @crvernon, thanks for the invitation, but I need to decline - I'm going away for holidays entire July. See you in August! 👋

@crvernon
Copy link

No problem, thanks @jromanowska!

@crvernon
Copy link

@editorialbot invite @sneakers-the-rat as editor

👋 @sneakers-the-rat - are you available to take this one on?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@timothyas
Copy link

@editorialbot generate pdf

@crvernon I was able to reduce the paper length dramatically from what it was, to ~1600 words. Please let me know if this is acceptable for JOSS. Thank you!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

iharm3D: Vectorized General Relativistic Magnetohydrodynamics
Submitting author: @bprather
Handling editor: @eloisabentivegna (Active)
Reviewers: @bgiacoma, @cpalenzuela
Similarity score: 0.6248

High-performance neural population dynamics modeling enabled by scalable computational infrastructure
Submitting author: @a9p
Handling editor: @emdupre (Active)
Reviewers: @richford, @tachukao
Similarity score: 0.6144

ACHR.cu: GPU-accelerated sampling of metabolic networks
Submitting author: @marouenbg
Handling editor: @lpantano (Active)
Reviewers: @wmegchel, @prasunanand
Similarity score: 0.6030

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia
Submitting author: @lluisjofre
Handling editor: @diehlpk (Active)
Reviewers: @ctdegroot, @thomasgillis
Similarity score: 0.6014

starry_process: Interpretable Gaussian processes for stellar light curves
Submitting author: @rodluger
Handling editor: @arfon (Active)
Reviewers: @nespinoza, @j-faria
Similarity score: 0.5992

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

Thanks @timothyas - we will let the assigned topic editor and reviewers provide feedback before I ask for any further cuts. Thanks for knocking this out quickly!

@editorialbot generate pdf

@crvernon I was able to reduce the paper length dramatically from what it was, to ~1600 words. Please let me know if this is acceptable for JOSS. Thank you!

@sneakers-the-rat
Copy link

@editorialbot assign @sneakers-the-rat as editor

yes i would be happy to :)

@editorialbot
Copy link
Collaborator Author

Assigned! @sneakers-the-rat is now the editor

@sneakers-the-rat
Copy link

It looks like climate modeling is one of the major intended applications - maybe we can find one reviewer who is a climate modeler and maybe the other is a more general neural networks person? Are there any people the authors would like to recommend as reviewers?

Otherwise I see that @SarthakJariwala , @trontrytel , and @Zeitsperre might be a good fit here - are any of y'all interested in reviewing this package?

@timothyas
Copy link

Thank you @sneakers-the-rat! I can recommend Troy Arcomano (GitHub username: Arcomano1234) who has extensive experience with Echo State Networks and ML more broadly, applied to weather forecasting. His work is cited in the "Previously existing software" section of our paper.

@sneakers-the-rat
Copy link

That sounds perfect, @Arcomano1234 would you be willing to review this package?

@Arcomano1234
Copy link

Yes of course!

@Zeitsperre
Copy link

Hi there, thanks for thinking of me, but I've been alternating between vacationing and swamped at work for the last few months. Keep me in mind for other similar projects, though!

@timothyas
Copy link

Hi @sneakers-the-rat I just wanted to check in on this, is there anything that I can do to help move this review along? Thanks!

@timothyas
Copy link

Hello @sneakers-the-rat @crvernon or anyone, is there anything I can do to help move this review along? This paper has been sitting for a few months now.

Thank you!

@crvernon
Copy link

@timothyas let me reach out to @sneakers-the-rat internally and see if I can make contact. If not, I will reassign this to another editor and we will get it moving. Thanks!

@crvernon
Copy link

@editorialbot remind me in two days

@editorialbot
Copy link
Collaborator Author

Reminder set for @crvernon in two days

@timothyas
Copy link

Thank you @crvernon!

@sneakers-the-rat
Copy link

apologies for the delay, i was out of work for a bit and the return has been rocky. let's get this show on the road

@sneakers-the-rat
Copy link

@editorialbot add @Arcomano1234 as reviewer

@editorialbot
Copy link
Collaborator Author

@Arcomano1234 added to the reviewers list!

@sneakers-the-rat
Copy link

sneakers-the-rat commented Sep 23, 2024

Searching in the db for a few more reviewers, I see @pitmonticone @wiljnich / @wiljnichepa and @bradyrx having previously volunteered as reviewers and having expertise in predictive modeling/climate/physical modeling - would any of you be willing to review this work?

@sneakers-the-rat
Copy link

@editorialbot remind me in one day

@editorialbot
Copy link
Collaborator Author

Reminder set for @sneakers-the-rat in one day

@wiljnich
Copy link

@sneakers-the-rat I am available and willing to review.

@sneakers-the-rat
Copy link

Fabulous! that's the two reviewers we need. since it's been a few months, can i have confirmation from @Arcomano1234 that he is still willing to review here? then let's start the review :)

@Arcomano1234
Copy link

Yes, I am more than happy to still review. I have a preliminary review and I have tried playing around with the code the last few months.

@editorialbot
Copy link
Collaborator Author

👋 @sneakers-the-rat, please take a look at the state of the submission (this is an automated reminder).

@editorialbot
Copy link
Collaborator Author

👋 @crvernon, please take a look at the state of the submission (this is an automated reminder).

@sneakers-the-rat
Copy link

@editorialbot add @wiljnich as reviewer

@editorialbot
Copy link
Collaborator Author

@wiljnich added to the reviewers list!

@sneakers-the-rat
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

8 participants