Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: BatteryRateCap: A Python Package for Comparative Battery Rate Capability Analysis #6261

Closed
editorialbot opened this issue Jan 22, 2024 · 12 comments
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @dorishung12 (Chih-Hsuan Hung)
Repository: https://github.com/BatteryDesign/BatteryRateCap/
Branch with paper.md (empty if default branch):
Version: v0.1.2
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7484ce3093f92e85cce1ddc971291484"><img src="https://joss.theoj.org/papers/7484ce3093f92e85cce1ddc971291484/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7484ce3093f92e85cce1ddc971291484/status.svg)](https://joss.theoj.org/papers/7484ce3093f92e85cce1ddc971291484)

Author instructions

Thanks for submitting your paper to JOSS @dorishung12. Currently, there isn't a JOSS editor assigned to your paper.

@dorishung12 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Jan 22, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (666.3 files/s, 158853.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10             49            346            550
Markdown                         2             31              1            288
YAML                             2              7              9            211
Jupyter Notebook                 4              0           2979            166
TeX                              1              0              0            100
TOML                             1              0              0             31
-------------------------------------------------------------------------------
SUM:                            20             87           3335           1346
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1021/acsenergylett.1c00870 is OK
- 10.1016/j.joule.2020.12.026 is OK
- 10.1021/acsenergylett.1c01710 is OK
- 10.1038/s41467-019-09792-9 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1021/acsenergylett.2c02208 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1323

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

liionpack: A Python package for simulating packs of batteries with PyBaMM
Submitting author: @TomTranter
Handling editor: @timtroendle (Active)
Reviewers: @EricaEgg, @mefuller, @yangbai90
Similarity score: 0.8323

fuelcell: A Python package and graphical user interface for electrochemical data analysis
Submitting author: @samaygarg
Handling editor: @jgostick (Active)
Reviewers: @jlopata21, @shimpalee
Similarity score: 0.8312

impedance.py: A Python package for electrochemical impedance analysis
Submitting author: @mdmurbach
Handling editor: @mbobra (Active)
Reviewers: @ma-sadeghi, @EricaEgg
Similarity score: 0.8268

Fruitbat: A Python Package for Estimating Redshifts of Fast Radio Bursts
Submitting author: @abatten
Handling editor: @xuanxu (Active)
Reviewers: @zingale
Similarity score: 0.7981

FitBenchmarking: an open source Python package comparing data fitting software
Submitting author: @tyronerees
Handling editor: @dhhagan (Active)
Reviewers: @johnsamuelwrites, @djmitche
Similarity score: 0.7979

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 22, 2024
@kyleniemeyer
Copy link

Hello @dorishung12, due to the relatively small size of your package (550 source lines of code), the editorial team is going to review your submission to make sure it means our requirements for substantial scholarly effort. We will hopefully get back to you within a week or so. In the meantime, any additional context you can give would be helpful.

@kyleniemeyer
Copy link

Hello @dorishung12, unfortunately, upon further review, the JOSS editorial team has found that your submission does not meet our requirements for substantial scholarly effort due to its relatively small size. It does look well packaged and useful, and we would consider future submissions if it grew substantially in size and functionality.

In the meantime, we encourage you to pursue alternate methods of archiving your software and creating a citeable object, including:

  • Follow GitHub’s guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work.
  • Inquire whether your software might be considered by communities such as pyOpenSci.

@kyleniemeyer
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

2 participants