[PRE REVIEW]: AHGestimation: An R package for Computing robust, mass preserving Hydraulic Geometries and Rating Curves

[editorialbot]

Submitting author: @mikejohnson51 (J. Micahel Johnson)
Repository: https://github.com/mikejohnson51/AHGestimation/
Branch with paper.md (empty if default branch):
Version: v0.2
Editor: @crvernon
Reviewers: @mabesa, @mengqi-z
Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b"><img src="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg)](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b)

Author instructions

Thanks for submitting your paper to JOSS @mikejohnson51. Currently, there isn't a JOSS editor assigned to your paper.

@mikejohnson51 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (853.8 files/s, 262363.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      11           2613           2665          10087
HTML                            35           1447            114           5287
R                               11            264            185            802
Rmd                              6            295            414            595
CSS                              8            106             82            463
Markdown                         4             96              0            312
TeX                              1              0              0            207
YAML                             6             31              4            165
XML                              1              0              0            105
Sass                             1              4              0             71
SVG                              1              0              1             11
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            86           4856           3465          18106
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1422

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.5194/hess-26-6121-2022 is OK

MISSING DOIs

- 10.3133/pp252 may be a valid DOI for title: The hydraulic geometry of stream channels and some physiographic implications
- 10.1002/aaai.12035 may be a valid DOI for title: Knowledge graphs to support real-time flood impact evaluation
- 10.1016/j.jhydrol.2018.07.020 may be a valid DOI for title: Field verification of analytical at-a-station hydraulic-geometry relations
- 10.1111/1752-1688.12661 may be a valid DOI for title: River channel geometry and rating curve estimation using height above the nearest drainage
- 10.20944/preprints202212.0390.v1 may be a valid DOI for title: Determining Feature Based Hydraulic Geometry and Rating Curves using a Physically Based, Computationally Efficient Framework
- 10.1016/j.envsoft.2020.104927 may be a valid DOI for title: Mainstems: A logical data model implementing mainstem and drainage basin feature types based on WaterML2 Part 3: HY Features concepts
- 10.22541/essoar.167415214.45806648/v1 may be a valid DOI for title: Comprehensive analysis of the NOAA National Water Model: A call for heterogeneous formulations and diagnostic model selection
- 10.1016/j.jhydrol.2017.01.038 may be a valid DOI for title: Statistical filtering of river survey and streamflow data for improving At-A-Station hydraulic geometry relations
- 10.1111/jawr.12282 may be a valid DOI for title: Development and evaluation of bankfull hydraulic geometry relationships for the physiographic regions of the United States
- 10.1111/1752-1688.12460 may be a valid DOI for title: Development and comparison of multiple regression models to predict bankfull channel dimensions for use in hydrologic models

INVALID DOIs

- None

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[kthyng]

Hi @mikejohnson51 and thanks for your submission. Since the lines of code is on the small side (looking at the R code, being < 1000), I will ping the editorial board to take a look and see if this is in scope for substantial scholarly effort. This will take a few weeks, thanks for your patience.

[kthyng]

@editorialbot query scope

[editorialbot]

Submission flagged for editorial review.

[editorialbot]

Five most similar historical JOSS papers:

morphMan: Automated manipulation of vascular geometries
Submitting author: @aslakbergersen
Handling editor: @trallard (Retired)
Reviewers: @brainstorm, @rlizzo
Similarity score: 0.8110

rigr: Regression, Inference, and General Data Analysis Tools in R
Submitting author: @yiqunchen
Handling editor: @osorensen (Active)
Reviewers: @stefanocoretta, @tomsing1
Similarity score: 0.8092

riversCentralAsia: An R package to support data pre- and postprocessing for hydrological modelling with RS MINERVE
Submitting author: @mabesa
Handling editor: @crvernon (Active)
Reviewers: @mengqi-z, @tonyewong
Similarity score: 0.8063

tidyhydat: Extract and Tidy Canadian Hydrometric Data
Submitting author: @boshek
Handling editor: @arfon (Active)
Reviewers: @arfon
Similarity score: 0.8047

The hhi Package: Streamlined Calculation and Visualization of Herfindahl-Hirschman Index Scores
Submitting author: @pdwaggoner
Handling editor: @leeper (Retired)
Reviewers: @cskovron
Similarity score: 0.8031

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

Hi @mikejohnson51 and thanks for your patience. This submission has been difficult to query for scope because it is borderline with votes both up and down. What has put me over the edge to send this to review is that it has been and seems to be continued to use in the community, which is one of the items we look for in deciding whether a submission is in scope. It is possible this will come up again during the review process in which case typically the reviewer opinion takes precedence, but we'll see what happens.

[kthyng]

@editorialbot invite @crvernon as editor

[editorialbot]

Invitation to edit this submission sent!

[kthyng]

@crvernon Would you be interested in editing this submission?

[crvernon]

@kthyng No problem!

[crvernon]

@editorialbot assign me as editor

[editorialbot]

Assigned! @crvernon is now the editor

[crvernon]

👋 @mikejohnson51 , I'll be your editor for this submission. While I am rounding up some reviewers (we will need at least two to kick off into full review), would you mind addressing the following missing DOI in your paper? Thanks!

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.5194/hess-26-6121-2022 is OK

MISSING DOIs

- 10.3133/pp252 may be a valid DOI for title: The hydraulic geometry of stream channels and some physiographic implications
- 10.1002/aaai.12035 may be a valid DOI for title: Knowledge graphs to support real-time flood impact evaluation
- 10.1016/j.jhydrol.2018.07.020 may be a valid DOI for title: Field verification of analytical at-a-station hydraulic-geometry relations
- 10.1111/1752-1688.12661 may be a valid DOI for title: River channel geometry and rating curve estimation using height above the nearest drainage
- 10.20944/preprints202212.0390.v1 may be a valid DOI for title: Determining Feature Based Hydraulic Geometry and Rating Curves using a Physically Based, Computationally Efficient Framework
- 10.1016/j.envsoft.2020.104927 may be a valid DOI for title: Mainstems: A logical data model implementing mainstem and drainage basin feature types based on WaterML2 Part 3: HY Features concepts
- 10.22541/essoar.167415214.45806648/v1 may be a valid DOI for title: Comprehensive analysis of the NOAA National Water Model: A call for heterogeneous formulations and diagnostic model selection
- 10.1016/j.jhydrol.2017.01.038 may be a valid DOI for title: Statistical filtering of river survey and streamflow data for improving At-A-Station hydraulic geometry relations
- 10.1111/jawr.12282 may be a valid DOI for title: Development and evaluation of bankfull hydraulic geometry relationships for the physiographic regions of the United States
- 10.1111/1752-1688.12460 may be a valid DOI for title: Development and comparison of multiple regression models to predict bankfull channel dimensions for use in hydrologic models

INVALID DOIs

- None

[crvernon]

👋 @boshek - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[crvernon]

👋 @mabesa - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[mikejohnson51]

Hi @crvernon thanks for taking on this submission (and @kthyng for diligently tracking it through!). I can fix those DOI's ASAP. I also saw that suggested reviewers could be helpful. If that is the case, and in addition to those you already pinged, (1) remcdermott (Pathways intern at NOAA and Master student at U. Alabama) would be a good fit given her thesis and work at NOAA. (2) thodson-usgs looks to be an excellent fit based on his contributions to the USGS rating curve and data retrieval packages. Thanks again for the opportunity.

[crvernon]

Thanks @mikejohnson51 !

[mabesa]

Sure @crvernon
Rating curves are not my area of expertise, nor am I working with USGS data but if this is not a concern for anybody involved I can make time for a review towards the end of the year.

[crvernon]

@mabesa I think you are topic adjacent and having experience as a member of the JOSS community who has been through the publishing process with an R package you would be a great fit. I also think a review new the end of the month is perfectly OK. So I'll sign you up! Thank you!

[crvernon]

@editorialbot add @mabesa as reviewer

[editorialbot]

@mabesa added to the reviewers list!

[crvernon]

👋 @remcdermott - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[crvernon]

👋 @mengqi-z - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[mengqi-z]

@crvernon, Thank you for the invitation. I accept the opportunity to review this JOSS submission.

[crvernon]

@editorialbot add @mengqi-z as reviewer

[editorialbot]

@mengqi-z added to the reviewers list!

[crvernon]

👋 - Alright @mikejohnson51 , @mabesa , and @mengqi-z - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

[crvernon]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #6145.