-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Mold: a LAMMPS package to compute interfacial free energies and nucleation rates #5990
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Couldn't check the bibtex because branch name is incorrect: https://github.com/AndresRTejedor/Mold/tree/joss/joss |
1 similar comment
Couldn't check the bibtex because branch name is incorrect: https://github.com/AndresRTejedor/Mold/tree/joss/joss |
@editorialbot check repository |
Couldn't check the bibtex because branch name is incorrect: https://github.com/AndresRTejedor/Mold/tree/joss/joss |
@editorialbot set main as branch |
Done! branch is now main |
@editorialbot check repository |
|
Failed to discover a |
@editorialbot set joss as branch |
Done! branch is now joss |
@editorialbot check references |
|
Note to editors, this is a re-submission (see previous submission: #5958). |
@AndresRTejedor thanks for this re-submission. Initially I rejected this submission based on its apparent small size from the software report over in #5958. There I perceived the work to be contained in <50 lines of Python, and <300 lines of C++ (the counts were however based on the Furthermore, I've had a fellow member of the editorial board, @lucydot, check this submission in terms of scope, and she believes it may be in scope, and has offered to edit this work. @AndresRTejedor, in relation to the above software report, what code portions would you say capture the core aspects of this work in terms of functionality and your original work? Is it mainly the Python and C++ code? Or are Fortran and JavaScript codes also your original developments? (I ask the latter as in some cases libraries from others are provided to support the project, and in some cases JavaScript is auto-generated to facilitate a GUI wrapper for instance) For the moment, @AndresRTejedor, can you please address the above potentially missing DOIs? ☝️ Note also, that you can remove any entries from the |
@editorialbot invite @lucydot as editor |
Invitation to edit this submission sent! |
@editorialbot assign me as editor |
Assigned! @lucydot is now the editor |
Hello @AndresRTejedor I will be your editor for this submission 👋 I point you to the comment from Kevin above; your answer here will also help finding appropriate reviewers. |
Dear @lucydot Thank you very much for reconsidering the resubmission of our paper. Regarding Kevin comments: -The code is entirely written by the authors of the work apart from the JavaScript which is an auto-generated code. More precisely: -The DOIs are missing because the references are copied from Scholar that does not include DOIs. I will include all the DOIs as soon as possible thoughtout this morning. I will re-generate the pdf when everything is ready. Many thanks for the possitive feeback. Looking forward to continuing the review process. On behalf of all the authors. |
@editorialbot generate pdf |
@editorialbot generate pdf |
Five most similar historical JOSS papers: MetalWalls: A classical molecular dynamics software dedicated to the simulation of electrochemical systems MCSD: A MATLAB Tool for Monte-Carlo Simulations of Diffusion in biological Tissues Computing diffusion coefficients in macromolecular simulations: the Diffusion Coefficient Tool for VMD FitSNAP: Atomistic machine learning with LAMMPS polypy - Analysis Tools for Solid State Molecular Dynamics and Monte Carlo Trajectories |
Hi @AndresRTejedor - @AndresRTejedor Thanks for your comments. I've re-read the paper:
If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission. |
@editorialbot generate pdf |
Five most similar historical JOSS papers: MetalWalls: A classical molecular dynamics software dedicated to the simulation of electrochemical systems FitSNAP: Atomistic machine learning with LAMMPS Computing diffusion coefficients in macromolecular simulations: the Diffusion Coefficient Tool for VMD MCSD: A MATLAB Tool for Monte-Carlo Simulations of Diffusion in biological Tissues NLMech: Implementation of finite difference/meshfree discretization of nonlocal fracture models |
Dear @lucydot , I have amended the reference For the Referees I propose the following:
Many thanks |
Thanks @AndresRTejedor for the suggestions and update. @merrygoat, @mattwthompson, @marjanAlbouye - 👋 are you available to review this submission to JOSS? |
I'll take on reviewing this |
Yes, I’d be happy to review this. |
@editorialbot add @mattwthompson as reviewer |
@mattwthompson added to the reviewers list! |
@editorialbot add @marjanAlbouye as reviewer |
@marjanAlbouye added to the reviewers list! |
Thank you for agreeing to review this paper @mattwthompson and @marjanAlbouye ✨ I'm going to ask editorial-bot to start the review, it will appear in a separate thread. There will be instructions at the top of the thread, and please let me know if you have any other questions about the process. We aim to complete reviews in 4-6 weeks, and as it is an iterative process, its best to get started within a week or two. |
@editorialbot start review |
OK, I've started the review over in #6083. |
Submitting author: @AndresRTejedor (Andrés R. Tejedor)
Repository: https://github.com/AndresRTejedor/Mold
Branch with paper.md (empty if default branch): joss
Version: LAMMPS 2023
Editor: @lucydot
Reviewers: @mattwthompson, @marjanAlbouye
Managing EiC: Kevin M. Moerman
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @AndresRTejedor. Currently, there isn't a JOSS editor assigned to your paper.
@AndresRTejedor if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: