Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyTASER: Simulating transient absorption spectroscopy (TAS) for crystals from first principles #5985

Closed
editorialbot opened this issue Oct 25, 2023 · 24 comments
Assignees
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 25, 2023

Submitting author: @savya10 (Savyasanchi Aggarwal)
Repository: https://github.com/WMD-group/PyTASER
Branch with paper.md (empty if default branch): paper
Version: v2.2.0
Editor: @jgostick
Reviewers: @obaica, @JosePizarro3
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931"><img src="https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931/status.svg)](https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931)

Author instructions

Thanks for submitting your paper to JOSS @savya10. Currently, there isn't a JOSS editor assigned to your paper.

@savya10 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 25, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=4.43 s (13.6 files/s, 94327.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             12              0              0         411553
Python                          10            393            422           2150
Jupyter Notebook                 3              0           1237            478
TeX                              1             17              0            241
YAML                             7             44             34            218
reStructuredText                 8            119            108            206
Markdown                         2             64              0            174
DOS Batch                        1              8              1             26
SVG                              1              0              1             16
JSON                            13              0              0             13
make                             1              4              7              9
TOML                             1              2              1              8
-------------------------------------------------------------------------------
SUM:                            60            651           1811         415092
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1720

@editorialbot
Copy link
Collaborator Author

@Kevin-Mattheus-Moerman
Copy link
Member

@savya10 thanks for this submission. I am the AEiC on this track and here to help with initial steps.

It looks like your paper is not compiling because rather than just a newline on line 37, you have a "tab" "character". If you replace that line an actual empty line I think that might fix it. Can you update the paper? Once you have done that, you can call @editorialbot generate pdf here to retry the paper compilation.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @jgostick as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@savya10
Copy link

savya10 commented Oct 25, 2023

Thanks @Kevin-Mattheus-Moerman for the help! Have updated now.

@savya10
Copy link

savya10 commented Oct 25, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Galore: Broadening and weighting for simulation of photoelectron spectroscopy
Submitting author: @ajjackson
Handling editor: @arfon (Active)
Reviewers: @shyamd
Similarity score: 0.8227

pyscal: A python module for structural analysis of atomic environments
Submitting author: @srmnitc
Handling editor: @melissawm (Retired)
Reviewers: @lucydot, @bocklund
Similarity score: 0.8204

sumo: Command-line tools for plotting and analysis of periodic ab initio calculations
Submitting author: @utf
Handling editor: @kyleniemeyer (Active)
Reviewers: @jarvist, @cfgoldsmith
Similarity score: 0.8165

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices
Submitting author: @ljakoster
Handling editor: @rkurchin (Active)
Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie
Similarity score: 0.8164

PiSCAT: A Python Package for Interferometric Scattering Microscopy
Submitting author: @po60nani
Handling editor: @emdupre (Active)
Reviewers: @ziatdinovmax, @aquilesC
Similarity score: 0.8135

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@savya10
Copy link

savya10 commented Oct 25, 2023

Here are some potential reviewers for this:

Pepe Marquez
Gang Tang (obaica)
Andrew S. Rosen

@jgostick
Copy link

@editorialbot assign @jgostick as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @jgostick is now the editor

@jgostick
Copy link

@editorialbot add @obaica as reviewer

@editorialbot
Copy link
Collaborator Author

@obaica added to the reviewers list!

@jgostick
Copy link

@editorialbot add @JosePizarro3 as reviewer

@editorialbot
Copy link
Collaborator Author

@JosePizarro3 added to the reviewers list!

@jgostick
Copy link

@editorialbot begin review

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@jgostick
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5999.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Galore: Broadening and weighting for simulation of photoelectron spectroscopy
Submitting author: @ajjackson
Handling editor: @arfon (Active)
Reviewers: @shyamd
Similarity score: 0.8225

pyscal: A python module for structural analysis of atomic environments
Submitting author: @srmnitc
Handling editor: @melissawm (Retired)
Reviewers: @lucydot, @bocklund
Similarity score: 0.8221

sumo: Command-line tools for plotting and analysis of periodic ab initio calculations
Submitting author: @utf
Handling editor: @kyleniemeyer (Active)
Reviewers: @jarvist, @cfgoldsmith
Similarity score: 0.8185

PiSCAT: A Python Package for Interferometric Scattering Microscopy
Submitting author: @po60nani
Handling editor: @emdupre (Active)
Reviewers: @ziatdinovmax, @aquilesC
Similarity score: 0.8162

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices
Submitting author: @ljakoster
Handling editor: @rkurchin (Active)
Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie
Similarity score: 0.8161

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

4 participants