Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Reducing the efforts to create reproducible analysis code with FieldTrip #5250

Closed
editorialbot opened this issue Mar 13, 2023 · 43 comments
Assignees
Labels
Makefile Matlab pre-review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 13, 2023

Submitting author: @matsvanes (Mats W.J. van Es)
Repository: https://github.com/fieldtrip/fieldtrip
Branch with paper.md (empty if default branch): JOSS
Version: fieldtrip/fieldtrip@9cfc0a7
Editor: @crsl4
Reviewers: @gflofst, @ashahide
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7f09b30f96082cab883d4dad60195e97"><img src="https://joss.theoj.org/papers/7f09b30f96082cab883d4dad60195e97/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7f09b30f96082cab883d4dad60195e97/status.svg)](https://joss.theoj.org/papers/7f09b30f96082cab883d4dad60195e97)

Author instructions

Thanks for submitting your paper to JOSS @matsvanes. Currently, there isn't a JOSS editor assigned to your paper.

@matsvanes if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Mar 13, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/nar/gky379 is OK
- 10.3389/fnins.2018.00261 is OK
- 10.3389/fninf.2012.00007 is OK
- 10.1038/nrn3475 is OK
- 10.1111/nyas.13325 is OK
- 10.1016/j.neuron.2017.10.013 is OK
- 10.3389/fninf.2011.00013 is OK
- 10.1093/bioinformatics/bth361 is OK
- 10.1155/2011/156869 is OK
- 10.1126/science.aac4716 is OK
- 10.1016/j.neuroimage.2019.06.046 is OK
- 10.1016/S1053-8119(03)00185-X is OK
- 10.1177/0956797611417632 is OK
- 10.1371/journal.pbio.2000797 is OK
- 10.1017/S0140525X17001972 is OK

MISSING DOIs

- 10.1007/3-211-27183-x_1 may be a valid DOI for title: MATLAB

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=42.93 s (169.8 files/s, 28198.5 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
MATLAB                                5647          95785         230136         480408
C                                      829          33375          46894         162300
C++                                    109           6363           6643          25657
C/C++ Header                           283           8799          18127          22648
make                                   115           2891           1412           9397
TeX                                     19           1676            623           9097
Fortran 77                              36           1743           3894           7722
Java                                    39           1069           1661           5194
HTML                                    40            598           1060           5020
Bourne Shell                            20            961           1044           2710
Windows Module Definition                8            122              0           2437
Arduino Sketch                           7            536            904           2303
Markdown                                27            499              0           1150
XML                                     14             18             43           1005
TypeScript                               1              0              0           1001
C Shell                                 29            148            127            784
Expect                                   6             17              0            783
Ruby                                     4              0              0            603
Python                                   4            173             94            532
MSBuild script                           2              0              0            455
Mathematica                              3              9              0            220
Perl                                     1             40             81            220
XSLT                                     1             47             21            217
sed                                      5              8              0            164
ProGuard                                 7             50             25            141
CMake                                    3             58             16            107
Ant                                      2             16              2            100
Scheme                                   1              0              0             78
CSS                                      1             14              2             66
INI                                      9              6              5             59
Bourne Again Shell                       3              8              0             40
DOS Batch                                3             11              1             39
reStructuredText                         1             18              0             33
awk                                      6             15              0             29
Qt Project                               2              6              0             18
MUMPS                                    1              4              0             14
YAML                                     2              0              0             11
Solidity                                 2              0              0             10
---------------------------------------------------------------------------------------
SUM:                                  7292         155083         312815         742772
---------------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1579

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @chartgerink as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@chartgerink do you think you can help edit this work? I thought that the "reproducible science" aspect might connect with you. Note, there are a number of EMG/ECG/EEG/signal processing papers in JOSS already, and you might check if reviewers for those are applicable to this submission too.

@chartgerink
Copy link
Member

@Kevin-Mattheus-Moerman sorry I'd prefer not to - I'm swamped with other tasks and I do not feel up to the task to edit a MATLAB based piece.

@Kevin-Mattheus-Moerman
Copy link
Member

@crsl4 do you think this submission is something you could help edit?

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @crsl4 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

👋 @crsl4 do you think you can help with this one?

@crsl4
Copy link

crsl4 commented Mar 23, 2023

Sorry, just back from break and catching up with piles of emails. Yes, I can edit it, but I might be slow as is one of my first papers to serve as editor.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign @crsl4 as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crsl4 is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

That is great @crsl4! Take your time. And I am here to help if you have any questions.

@crsl4
Copy link

crsl4 commented Apr 8, 2023

Of the list of potential reviewers:
@sealhuang @nicoguaro @nirum Hello! Would you be interested in reviewing this paper? :)

@nicoguaro
Copy link

Of the list of potential reviewers: @sealhuang @nicoguaro @nirum Hello! Would you be interested in reviewing this paper? :)

Currently in reviewing an article and I think that I would have to decline this invitation.

@nirum
Copy link

nirum commented Apr 10, 2023

I'm also unavailable at the moment!

@matsvanes
Copy link

Are there any updates on this @crsl4 ?

@crsl4
Copy link

crsl4 commented May 17, 2023

Oops! Sorry! Dropped the ball while wrapping up the semester. I will invite more people.

@crsl4
Copy link

crsl4 commented May 17, 2023

@stevokeyo Hello! Would you be interested in reviewing this paper? :)

@crsl4
Copy link

crsl4 commented May 17, 2023

@eteq Hello! Would you be interested in reviewing this paper? :)

@crsl4
Copy link

crsl4 commented May 17, 2023

@gflofst Hello! Would you be interested in reviewing this paper? :)

@gflofst
Copy link

gflofst commented May 17, 2023

Yes! I cannot get it to before June 1 week though. Is that ok?

@crsl4
Copy link

crsl4 commented May 18, 2023

no problem at all! Thank you Jay!

@crsl4
Copy link

crsl4 commented May 18, 2023

@editorialbot add @gflofst as reviewer

@editorialbot
Copy link
Collaborator Author

@gflofst added to the reviewers list!

@crsl4
Copy link

crsl4 commented Jun 15, 2023

@daissi Hello! Would you be interested in reviewing this paper? :)

@crsl4
Copy link

crsl4 commented Jun 15, 2023

@benmarwick Hello! Would you be interested in reviewing this paper? :)

@gflofst
Copy link

gflofst commented Jun 15, 2023

I had forgotten about this. I'll get it done hopefully on Friday. It is a light day so I should have time.

@benmarwick
Copy link

@crsl4 thank you for the invitation! Unfortunately I'm not at all familiar with Matlab, so I'm not capable of reviewing this, sorry about that.

@crsl4
Copy link

crsl4 commented Jun 15, 2023

Thanks Jay! I had not even started the "review process" because I need one more reviewer. But feel free to get started!

@crsl4
Copy link

crsl4 commented Jun 15, 2023

Ben, no worries! Thanks for responding!

@crsl4
Copy link

crsl4 commented Jun 16, 2023

@ashahide Hello! Would you be interested in reviewing this paper? :)

@crsl4
Copy link

crsl4 commented Jun 16, 2023

@LyceanEM Hello! Would you be interested in reviewing this paper? :)

@ashahide
Copy link

Definitely - I'll take a look this weekend.

@crsl4
Copy link

crsl4 commented Jun 16, 2023

Thank you, Andy! Much appreciated:)

@crsl4
Copy link

crsl4 commented Jun 16, 2023

@editorialbot add @ashahide as reviewer

@editorialbot
Copy link
Collaborator Author

@ashahide added to the reviewers list!

@crsl4
Copy link

crsl4 commented Jun 16, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Makefile Matlab pre-review TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

10 participants