-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: cRacklet: a spectral boundary integral method library for interfacial rupture simulation #3724
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @KParas, @srmnitc it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
👋 @srmnitc, please update us on how your review is going (this is an automated reminder). |
👋 @KParas, please update us on how your review is going (this is an automated reminder). |
Reminder set for @srmnitc in 2 weeks |
Reminder set for @KParas in 2 weeks |
@KParas How is your review going? |
@diehlpk Thanks for the reminder. I will finish it next week. |
@diehlpk I have finished my review at this point. I apologize for the delay. This code is quite nice, well written and has already been employed in a number of publications. As such, I believe it will be useful and hence should be published in JOSS. I have few issues which I opened in the repository:
Once the issues are addressed, I would be happy to check the remaining boxes. Thank you for the chance to review this nice software, and sorry for the delay. |
Thank you @srmnitc for your time and your encouraging review. I will try to address your points by next week. |
@helgee @kylebeggs @mkhoshbin1 would you be interested in reviewing this paper? |
Sorry, bit too far outside my comfort zone. |
@diehlpk I'd be willing. |
|
|
@srmnitc, @kylebeggs thanks for your reviews. We can not run JOSS without your help. |
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2892 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2892, then you can now move forward with accepting the submission by compiling again with the flag
|
@tiburoch can you please add this DOI to the paper? I am not sure why I missed that before accepting the paper. |
@diehlpk sorry this slips in when I updated this publication from its arxiv version to the published one. It is fixed now. |
@whedon generate pdf |
Hi @kyleniemeyer , thank you for the additional corrections. I accepted the merge request and it will be automatically merged when the CI is done (should take less than 1h). |
@whedon generate pdf |
@tiburoch bah, I missed one citation fix! Could you please change After that, we should be ready to publish. Thanks! |
@kyleniemeyer : it's done, the master branch is updated. |
@whedon generate pdf |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@tiburoch congratulations on your article's publication in JOSS! Many thanks to @srmnitc and @kylebeggs for reviewing this, and @diehlpk for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @tiburoch (Thibault Roch)
Repository: https://gitlab.com/cracklet/cracklet.git
Version: v1.0.0
Editor: @diehlpk
Reviewers: @srmnitc, @kylebeggs
Archive: 10.5281/zenodo.5865617
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kylebeggs & @srmnitc, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @kylebeggs
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @srmnitc
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: