Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: funsies: A minimalist, distributed and dynamic workflow engine #3231

Closed
whedon opened this issue Apr 30, 2021 · 34 comments
Closed

Comments

@whedon
Copy link

whedon commented Apr 30, 2021

Submitting author: @clavigne (Cyrille Lavigne)
Repository: https://github.com/aspuru-guzik-group/funsies
Version: v0.7.0
Editor: @diehlpk
Reviewers: @gflofst, @vijaysm
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @clavigne. Currently, there isn't an JOSS editor assigned to your paper.

@clavigne if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 30, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.15 s (514.0 files/s, 103559.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            10            639              0           6867
Python                          57           1304           1324           4879
Markdown                         6             75              0            380
TeX                              1             27              0            294
YAML                             1              0              0             40
INI                              2              3              0             29
Bourne Shell                     1             11             23             14
Mako                             1              0              0              8
-------------------------------------------------------------------------------
SUM:                            79           2059           1347          12511
-------------------------------------------------------------------------------


Statistical information for the repository 'cbb507920ec4c86c92184295' was
gathered on 2021/04/30.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Cyrille Lavigne                317         23835          14394          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Cyrille Lavigne            7316           30.7          2.2               12.40

@whedon
Copy link
Author

whedon commented Apr 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1063/5.0006002 is OK
- 10.1063/5.0004835 is OK
- 10.1063/5.0007045 is OK
- 10.1063/5.0004997 is OK
- 10.1063/5.0005188 is OK
- 10.1063/1.5144261 is OK
- 10.1016/j.matt.2021.02.017 is OK
- 10.1145/1330017.1330019 is OK
- 10.1093/bioinformatics/bts480 is OK
- 10.12688/f1000research.29032.2 is OK
- 10.1145/2807591.2807623 is OK
- 10.1007/10968987_3 is OK
- 10.1007/978-3-319-63688-7_19 is OK

MISSING DOIs

- 10.26434/chemrxiv.13008500.v1 may be a valid DOI for title: Automatic discovery of chemical reactions using imposed activation
- 10.21276/ijre.2018.5.5.4 may be a valid DOI for title: MapReduce: Simplified Data Processing on Large Clusters

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @diehlpk as editor

@diehlpk
Copy link
Member

diehlpk commented Apr 30, 2021

@whedon assign @diehlpk as editor

@whedon
Copy link
Author

whedon commented Apr 30, 2021

OK, the editor is @diehlpk

@diehlpk
Copy link
Member

diehlpk commented Apr 30, 2021

@Kevin-Mattheus-Moerman Sure, I can take this paper.

@diehlpk
Copy link
Member

diehlpk commented May 4, 2021

@clavigne Could you please name some potential reviewers?

@diehlpk
Copy link
Member

diehlpk commented May 4, 2021

Hey @daissi @wjakethompson @vijaysm @gflofst @camillescott would you be interested to review this paper?

@camillescott
Copy link

Sure, this is in my wheelhouse.

@vijaysm
Copy link

vijaysm commented May 4, 2021

If the others are busy, sure I can review it. I just have some deadlines near term, but can start in 2-3 weeks or so, if that works.

@diehlpk
Copy link
Member

diehlpk commented May 5, 2021

@whedon assign @camillescott as reviewer

@whedon whedon assigned camillescott and diehlpk and unassigned diehlpk May 5, 2021
@whedon
Copy link
Author

whedon commented May 5, 2021

OK, @camillescott is now a reviewer

@diehlpk
Copy link
Member

diehlpk commented May 5, 2021

@vijaysm I will wait for a few more days and if I could not find one additional reviewer, I will add you.

@wjakethompson
Copy link

I very rarely use Python, so this one is a little outside of my comfort zone.

@clavigne
Copy link

clavigne commented May 8, 2021

sorry for the delay, Ive had a very busy week.

I'd recommend Johannes Koester or someone from his group, Paolo Di Tommaso and Hilary J. Oliver. They are all working on similar codes (inspirations of sort).

Thank you!

@gflofst
Copy link

gflofst commented May 11, 2021

@diehlpk I would like to. My other one is finally making progress on the requested changes. I should be able to do this as well.

@diehlpk
Copy link
Member

diehlpk commented May 11, 2021

@whedon add @gflofst as reviewer

@whedon whedon assigned camillescott and unassigned camillescott and diehlpk May 11, 2021
@diehlpk
Copy link
Member

diehlpk commented May 11, 2021

Thanks @camillescott and @gflofst for reviewing the paper.

@diehlpk
Copy link
Member

diehlpk commented May 11, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented May 11, 2021

OK, I've started the review over in #3274.

@whedon whedon closed this as completed May 11, 2021
@diehlpk
Copy link
Member

diehlpk commented Jun 18, 2021

@vijaysm I will wait for a few more days and if I could not find one additional reviewer, I will add you.

@vijaysm Can you still review the paper? One reviewer disappeared and I could need some help here.

@vijaysm
Copy link

vijaysm commented Jun 18, 2021

@diehlpk I'm swamped until end of next week with a conference. But can review this after. Let me know if that timeline would work.

@diehlpk
Copy link
Member

diehlpk commented Jun 18, 2021

@diehlpk I'm swamped until end of next week with a conference. But can review this after. Let me know if that timeline would work.

Sure, that will work.

@diehlpk
Copy link
Member

diehlpk commented Jun 18, 2021

@whedon add @vijaysm as reviewer

@whedon
Copy link
Author

whedon commented Jun 18, 2021

OK, @vijaysm is now a reviewer

@clavigne
Copy link

@diehlpk Any news on this? Thanks.

@diehlpk
Copy link
Member

diehlpk commented Jul 14, 2021

@clavigne Not really @camillescott never responded, and I asked @vijaysm to replace her. We need to wait for his review to proceed.

@diehlpk
Copy link
Member

diehlpk commented Jul 14, 2021

@whedon remove @camillescott as reviewer

@whedon
Copy link
Author

whedon commented Jul 14, 2021

OK, @camillescott is no longer a reviewer

@diehlpk
Copy link
Member

diehlpk commented Jul 14, 2021

@vijaysm How is your review going?

@vijaysm
Copy link

vijaysm commented Jul 14, 2021

Thanks for the reminder. I'll start the review this Friday and should be able to complete it within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants