-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: medrxivr: Accessing and searching medRxiv and bioRxiv preprint data in R #2651
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @danielskatz it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
👋 @mcguinlu - thanks for your submission to JOSS. Unfortunately, even though this submission came via rOpenSci, this submission is out of scope for JOSS as we classify it a 'minor' submission (API wrapper). I've asked the rOpenSci folks to update their guidelines to make it a little clearer which rOpenSci packages might be considered out of scope here. / cc @karthik |
@whedon reject |
Paper rejected. |
Hi @arfon, Thanks for your comments, though I'll admit I am a little surprised that the package is not considered in scope. While
In addition, the main functionality of the package was developed before the medRxiv API came online - previously Finally, just to make you aware that the package has already been used in two published academic publications that I know of (see here and here) (COI: I am one of the co-authors on the second paper) I fully respect your decision as EiC, but just wanted to make sure that the decision wasn't due to an error on my part, in that I may not have accurately described Thanks for your continued consideration! Edit: I went looking out of interest, and just in case it helps, I would consider |
Good morning @arfon (& @danielskatz, for reference ), and happy Monday! As it's been a week, just flagging the above again in case it got lost in the mix - would be great to hear what you think, particularly re: comparison with |
Thanks @danielskatz! Also just flagging this to @maelle, as I know she has done a lot of work recently on updating the rOpenSci dev guide, and I agree with @arfon's point above that it might be useful to have clear guidelines on the types of rOpenSci packages that are considered out of scope by JOSS included in the rOpenSci dev guide. |
Thanks @mcguinlu. We have started a discussion to update the dev guide so it clearly reflects what might be out of scope for JOSS. |
@mcguinlu - we're going to process this in JOSS. |
This package has been reviewed by rOpenSci: ropensci/software-review#380 |
@whedon generate pdf |
@whedon check references |
|
@mcguinlu - can you merge ropensci/medrxivr#12 or let me know what part of it you disagree with? |
Also, is this code in zenodo or another archive? If so, what is the DOI for it there? In ropensci/software-review#380 (comment) it looks like that item is checked off... |
Hi @danielskatz, I've merged the changes you made in ropensci/medrxivr#12 into the main branch now. And the code for this package is archived by Zenodo. The Zenodo DOI is 10.5281/zenodo.3860023 |
@whedon set 10.5281/zenodo.3860023 as archive |
OK. 10.5281/zenodo.3860023 is the archive. |
In the zenodo archive, can you change the metadata so that the title and authors match those of the JOSS paper? |
Done - title and authors are now consistent between the JOSS paper and the Zenodo repo. |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1788 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1788, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @mcguinlu!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Awesome - thanks to everyone involved! 🥳 |
Submitting author: @mcguinlu (Luke A McGuinness)
Repository: https://github.com/ropensci/medrxivr
Version: v0.0.3
Editor: @danielskatz
Reviewer: @danielskatz
Archive: 10.5281/zenodo.3860023
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@danielskatz, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @danielskatz
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: