Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: medrxivr: Accessing and searching medRxiv and bioRxiv preprint data in R #2651

Closed
20 tasks done
whedon opened this issue Sep 8, 2020 · 35 comments
Closed
20 tasks done
Assignees
Labels
accepted published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci TeX

Comments

@whedon
Copy link

whedon commented Sep 8, 2020

Submitting author: @mcguinlu (Luke A McGuinness)
Repository: https://github.com/ropensci/medrxivr
Version: v0.0.3
Editor: @danielskatz
Reviewer: @danielskatz
Archive: 10.5281/zenodo.3860023

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3d6184f7a2d4fc3a8ad4c0bfacc560af"><img src="https://joss.theoj.org/papers/3d6184f7a2d4fc3a8ad4c0bfacc560af/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3d6184f7a2d4fc3a8ad4c0bfacc560af/status.svg)](https://joss.theoj.org/papers/3d6184f7a2d4fc3a8ad4c0bfacc560af)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@danielskatz, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Review checklist for @danielskatz

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mcguinlu) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Sep 8, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @danielskatz it looks like you're currently assigned to review this paper 🎉.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 8, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.22541/au.158516578.89167184 is OK
- 10.1136/bmj.l2301 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 8, 2020

@arfon
Copy link
Member

arfon commented Sep 14, 2020

👋 @mcguinlu - thanks for your submission to JOSS. Unfortunately, even though this submission came via rOpenSci, this submission is out of scope for JOSS as we classify it a 'minor' submission (API wrapper). I've asked the rOpenSci folks to update their guidelines to make it a little clearer which rOpenSci packages might be considered out of scope here.

/ cc @karthik

@arfon
Copy link
Member

arfon commented Sep 14, 2020

@whedon reject

@whedon
Copy link
Author

whedon commented Sep 14, 2020

Paper rejected.

@mcguinlu
Copy link

mcguinlu commented Sep 14, 2020

Hi @arfon,

Thanks for your comments, though I'll admit I am a little surprised that the package is not considered in scope.

While medrxivr does interact with the API, this is mainly as a precusor to searching the medRxiv database using complex search strategies and then bulk exporting the results to a .BIB file for further processing/analysis as part of a systematic literaure review. This functionality (reproducible + transparent searching, bulk export of records) is something that is not offered by either the medRxiv website or its API, or by any other package/tool, but is regularly requested by the health librarian community:

I have pretty much given up on medRxiv, it search interface is useless & unpredictable. I have many searches that I have rerun exactly the same week prior that have come back with inconsistent wacky results. No way should a search one week get 60 citations then 3000 next #medlibs

— Michelle Kraft (@krafty) August 13, 2020

anyone have a method for bulk export from medRxiv? #systematicreviews #rapidreviews #ukmedlibs #medlibs #thanks

— (((MarshallDozier))) (@mafrado) March 31, 2020

Re-amplifying this question. I'm grappling with medRxiv this morning and having issues downloading. Any ideas #medlibs people? https://t.co/pBB8j7hy8U

— Jane Falconer (@falkie71) April 24, 2020

In addition, the main functionality of the package was developed before the medRxiv API came online - previously medrxivr used webscraping to import the data (for example, see this commit point from back in February), which is why I think the designation as an "API wrapper" might not be accurate.

Finally, just to make you aware that the package has already been used in two published academic publications that I know of (see here and here) (COI: I am one of the co-authors on the second paper)

I fully respect your decision as EiC, but just wanted to make sure that the decision wasn't due to an error on my part, in that I may not have accurately described medrxivr in the paper I submitted.

Thanks for your continued consideration!


Edit: I went looking out of interest, and just in case it helps, I would consider medrxivr to be comparable to the JOSS-published chirps package, in that it provides access to the data via the API but also contains functions to work with the data once imported.

@mcguinlu
Copy link

Good morning @arfon (& @danielskatz, for reference ), and happy Monday!

As it's been a week, just flagging the above again in case it got lost in the mix - would be great to hear what you think, particularly re: comparison with chirps.

@danielskatz
Copy link

@mcguinlu asked me to reopen this so that he could further discuss it with @arfon and the JOSS team, so I am doing so

@danielskatz danielskatz reopened this Oct 7, 2020
@mcguinlu
Copy link

mcguinlu commented Oct 7, 2020

Thanks @danielskatz!

Also just flagging this to @maelle, as I know she has done a lot of work recently on updating the rOpenSci dev guide, and I agree with @arfon's point above that it might be useful to have clear guidelines on the types of rOpenSci packages that are considered out of scope by JOSS included in the rOpenSci dev guide.

@karthik
Copy link
Contributor

karthik commented Oct 7, 2020

Thanks @mcguinlu. We have started a discussion to update the dev guide so it clearly reflects what might be out of scope for JOSS.

@danielskatz
Copy link

@mcguinlu - we're going to process this in JOSS.

@danielskatz
Copy link

This package has been reviewed by rOpenSci: ropensci/software-review#380

@danielskatz
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 8, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Oct 8, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.22541/au.158516578.89167184 is OK
- 10.1136/bmj.l2301 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

@mcguinlu - can you merge ropensci/medrxivr#12 or let me know what part of it you disagree with?

@danielskatz
Copy link

Also, is this code in zenodo or another archive? If so, what is the DOI for it there? In ropensci/software-review#380 (comment) it looks like that item is checked off...

@mcguinlu
Copy link

mcguinlu commented Oct 9, 2020

Hi @danielskatz,

I've merged the changes you made in ropensci/medrxivr#12 into the main branch now. And the code for this package is archived by Zenodo. The Zenodo DOI is 10.5281/zenodo.3860023

@danielskatz
Copy link

@whedon set 10.5281/zenodo.3860023 as archive

@whedon
Copy link
Author

whedon commented Oct 9, 2020

OK. 10.5281/zenodo.3860023 is the archive.

@danielskatz
Copy link

In the zenodo archive, can you change the metadata so that the title and authors match those of the JOSS paper?

@mcguinlu
Copy link

mcguinlu commented Oct 9, 2020

Done - title and authors are now consistent between the JOSS paper and the Zenodo repo.

@danielskatz
Copy link

@whedon accept

@whedon whedon added the recommend-accept Papers recommended for acceptance in JOSS. label Oct 9, 2020
@whedon
Copy link
Author

whedon commented Oct 9, 2020

Attempting dry run of processing paper acceptance...

@whedon
Copy link
Author

whedon commented Oct 9, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.22541/au.158516578.89167184 is OK
- 10.1136/bmj.l2301 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Oct 9, 2020

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#1788

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1788, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

@danielskatz
Copy link

@whedon accept deposit=true

@whedon
Copy link
Author

whedon commented Oct 9, 2020

Doing it live! Attempting automated processing of paper acceptance...

@whedon whedon added accepted published Papers published in JOSS labels Oct 9, 2020
@whedon
Copy link
Author

whedon commented Oct 9, 2020

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon
Copy link
Author

whedon commented Oct 9, 2020

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.02651 joss-papers#1789
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02651
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@danielskatz
Copy link

Congratulations @mcguinlu!!

@whedon
Copy link
Author

whedon commented Oct 9, 2020

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02651/status.svg)](https://doi.org/10.21105/joss.02651)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02651">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02651/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02651/status.svg
   :target: https://doi.org/10.21105/joss.02651

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@mcguinlu
Copy link

mcguinlu commented Oct 9, 2020

Awesome - thanks to everyone involved! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci TeX
Projects
None yet
Development

No branches or pull requests

5 participants