Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Spleeter: a fast and state-of-the art music source separation tool with pre-trained models #2148

Closed
whedon opened this issue Mar 6, 2020 · 21 comments

Comments

@whedon
Copy link

whedon commented Mar 6, 2020

Submitting author: @romi1502 (Romain Hennequin)
Repository: https://github.com/deezer/spleeter
Version: v1.4.9
Editor: @terrytangyuan
Reviewers: @bmcfee , @faroit
Managing EiC: Kevin M. Moerman

Author instructions

Thanks for submitting your paper to JOSS @romi1502. Currently, there isn't an JOSS editor assigned to your paper.

@romi1502 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 6, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 6, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.18 s (279.0 files/s, 24565.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          30            504            897           1887
JSON                             9              0              0            275
YAML                             2              0             21            258
Markdown                         7             74              0            189
TeX                              1             15              1            135
make                             1              7              6             20
Jupyter Notebook                 1              0            192             10
-------------------------------------------------------------------------------
SUM:                            51            600           1117           2774
-------------------------------------------------------------------------------


Statistical information for the repository '2148' was gathered on 2020/03/06.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Félix Voituret                  44          1096           1067           39.66
Romain                           1          3242              0           59.44
Romain Hennequin                 1             4              2            0.11
Yusuke Goto                      1            10              1            0.20
fvoituret                        1             1              1            0.04
johnwmillr                       1             3              3            0.11
mmoussallam                      1             7              4            0.20
romi1502                         2             2              2            0.07
valrus                           1             6              3            0.17

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Félix Voituret              492           44.9          2.5               10.37
Romain Hennequin              4          100.0          1.2                0.00
Yusuke Goto                  10          100.0          0.9                0.00
johnwmillr                    3          100.0          2.1                0.00
mmoussallam                   7          100.0          0.0                0.00
romi1502                   2766       138300.0          0.0               14.61
valrus                        6          100.0          0.5                0.00

@whedon
Copy link
Author

whedon commented Mar 6, 2020

Reference check summary:

OK DOIs

- 10.1109/ICASSP.2019.8683555 is OK
- 10.5281/zenodo.3269749 is OK
- 10.1109/TSA.2005.858005 is OK
- 10.5281/zenodo.1117372 is OK
- 10.21105/joss.01667 is OK

MISSING DOIs

- https://doi.org/10.1007/978-3-319-93764-9_28 may be missing for title: The 2018 Signal Separation Evaluation Campaign

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Mar 6, 2020

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @arokem as editor

@whedon
Copy link
Author

whedon commented Mar 6, 2020

@arokem has been invited to edit this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@terrytangyuan @arokem could one of you edit this submission? Perhaps there is some reviewer overlap with: #1667

@openjournals openjournals deleted a comment from whedon Mar 7, 2020
@terrytangyuan
Copy link
Member

@whedon assign @terrytangyuan as editor

@whedon
Copy link
Author

whedon commented Mar 7, 2020

OK, the editor is @terrytangyuan

@terrytangyuan
Copy link
Member

Happy to edit this one. @romi1502 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

@romi1502
Copy link

romi1502 commented Mar 9, 2020

Hey @terrytangyuan.
Thank you for managing the review.
An obvious choice for the paper review would be faroit as he is the main author of an open source package which also deals with Source Separation (Open Unmix) though it may be considered as a conflict of interest. Otherwise, I don't know other people in the list. Anyone with experience in Python and audio/music processing should be skilled to review it.

@terrytangyuan
Copy link
Member

👋 @bmcfee, @hagenw @faroit if you would like to review for this submission, please let us know here! We need at least two reviewers.

@faroit
Copy link

faroit commented Mar 9, 2020

@terrytangyuan @romi1502 Great to see more audio papers here. I don't see a conflict of interest and can ensure that I would review the paper accordingly. But I let the editors decide....

@bmcfee
Copy link

bmcfee commented Mar 9, 2020

Sure, count me in.

@terrytangyuan
Copy link
Member

@whedon assign @bmcfee as reviewer

@whedon whedon assigned bmcfee and terrytangyuan and unassigned terrytangyuan Mar 9, 2020
@whedon
Copy link
Author

whedon commented Mar 9, 2020

OK, @bmcfee is now a reviewer

@terrytangyuan
Copy link
Member

@whedon add @faroit as reviewer

@whedon whedon assigned bmcfee and faroit and unassigned bmcfee and terrytangyuan Mar 9, 2020
@whedon
Copy link
Author

whedon commented Mar 9, 2020

OK, @faroit is now a reviewer

@terrytangyuan
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Mar 9, 2020

OK, I've started the review over in #2154.

@whedon whedon closed this as completed Mar 9, 2020
@terrytangyuan
Copy link
Member

Thanks! Look forward to your reviews in #2154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants