-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ggvoronoi: Voronoi Diagrams and Heatmaps with ggplot2 #1096
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @trinker, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Thanks @garretrc for this elegant Voronoi extension! I'll start raising issues at the code repo momentarily. As you address the issues, i'll check off the related items on my review checklist. If you think some of my issues aren't really problematic, or if you think my suggestions are not great, then please let me know in the issue thread and handle them as you see fit—i'll probably then better understand the issue and check it off for reviewing purposes. |
Thanks for the feedback! I've started to go through the issues on the ggvoronoi repository. I'll close issues on that repo if I'm confident the issue is resolved and comment if I have any questions. |
@corybrunson I've addressed each issue, one is still open and I've left a comment as justification. If you accept that reasoning you can close the issue, otherwise leave a comment and I can make further changes. Feel free to re-open any of the other issues if you feel my solutions aren't acceptable! Thank you. |
@whedon commands |
Here are some things you can ask me to do:
|
@whedon generate pdf |
|
@garretrc thanks for addressing all of the issues! You've resolved or explained them to my satisfaction. @yochannah i have completed my review and, conditional on my co-reviewer's feedback, recommend acceptance of the current GitHub version (garretrc/ggvoronoi@2b2821c). |
@garretrc Thanks for addressing the couple of GitHub issues. These have been addressed/resolved. @yochannah I have also completed my review and also recommend acceptance of the current GitHub version (garretrc/ggvoronoi@c9ba48f). |
@whedon generate pdf |
|
@corybrunson @trinker Thanks for the speedy reviews! 💯 @garretrc - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? |
DOI: 10.5281/zenodo.1933346 |
Thanks @yochannah @trinker @corybrunson for all your swift work and wonderful feedback! |
@whedon set 10.5281/zenodo.1933346 as archive |
OK. 10.5281/zenodo.1933346 is the archive. |
@arfon Okay, we're ready to accept! 🏆 Nice work, @garretrc and great job reviewing @trinker @corybrunson! |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#101 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#101, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@trinker, @corybrunson - many thanks for your reviews here and to @yochannah for editing this submission ✨ @garretrc - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @garretrc (Robert Garrett)
Repository: https://github.com/garretrc/ggvoronoi
Version: v0.8.2
Editor: @yochannah
Reviewer: @trinker, @corybrunson
Archive: 10.5281/zenodo.1933346
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@trinker & @corybrunson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @yochannah know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @trinker
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @corybrunson
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: