-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309032: jpackage does not work for module projects unless --module-path is specified #120
Conversation
👋 Welcome back airsquared! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@airsquared This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@airsquared |
Tagged the JBS issue. |
/sponsor |
@alexeysemenyukoracle Only Committers are allowed to sponsor changes. |
/sponsor |
Going to push as commit b86a0ce.
Your commit was automatically rebased without conflicts. |
@phohensee @airsquared Pushed as commit b86a0ce. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fixes an error when trying to add additional launchers in jpackage.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/120/head:pull/120
$ git checkout pull/120
Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.org/jdk21u.git pull/120/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 120
View PR using the GUI difftool:
$ git pr show -t 120
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/120.diff
Webrev
Link to Webrev Comment