JDK-8309032: jpackage does not work for module projects unless --module-path is specified

[airsquared]

JDK-8309032, JDK-8306488

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309032: jpackage does not work for module projects unless --module-path is specified (Bug - P4)

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14840/head:pull/14840
$ git checkout pull/14840

Update a local copy of the PR:
$ git checkout pull/14840
$ git pull https://git.openjdk.org/jdk.git pull/14840/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14840

View PR using the GUI difftool:
$ git pr show -t 14840

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14840.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @airsquared, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user airsquared" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@airsquared The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b26e01ef)

[openjdk]

@airsquared This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309032: jpackage does not work for module projects unless --module-path is specified

Reviewed-by: asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• 61ab270: 8310835: Address gaps in -Xlint:serial checks
• 5d57b5c: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance
• 71cac8c: 8311663: Additional refactoring of Locale tests to JUnit
• aa23fd9: 8311879: SA ClassWriter generates invalid invokedynamic code
• 6f66213: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
• b5b6f4e: 8312164: Refactor Arrays.hashCode for long, boolean, double, float, and Object arrays
• 14cf035: 8302987: Add uniform and spatially equidistributed bounded double streams to RandomGenerator
• d1c788c: 8312392: ARM32 build broken since 8311035
• c119037: 8311971: SA's ConstantPool.java uses incorrect computation to read long value in the constant pool
• 028068a: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
• ... and 93 more: https://git.openjdk.org/jdk/compare/aac903dbfb7dfb42464cad23aa9f1d536b55cfc1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @sashamatveev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[airsquared]

/integrate

[openjdk]

@airsquared
Your change (at version b26e01e) is now ready to be sponsored by a Committer.

[airsquared]

@alexeysemenyukoracle would you be able to sponsor this change? Thanks!

[alexeysemenyukoracle]

@sashamatveev would you like to review the change before I sponsor it?

[sashamatveev]

@alexeysemenyukoracle Looks good.

[alexeysemenyukoracle]

/sponsor

[openjdk]

Going to push as commit dfe764e.
Since your change was applied there have been 103 commits pushed to the master branch:

• 61ab270: 8310835: Address gaps in -Xlint:serial checks
• 5d57b5c: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance
• 71cac8c: 8311663: Additional refactoring of Locale tests to JUnit
• aa23fd9: 8311879: SA ClassWriter generates invalid invokedynamic code
• 6f66213: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
• b5b6f4e: 8312164: Refactor Arrays.hashCode for long, boolean, double, float, and Object arrays
• 14cf035: 8302987: Add uniform and spatially equidistributed bounded double streams to RandomGenerator
• d1c788c: 8312392: ARM32 build broken since 8311035
• c119037: 8311971: SA's ConstantPool.java uses incorrect computation to read long value in the constant pool
• 028068a: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
• ... and 93 more: https://git.openjdk.org/jdk/compare/aac903dbfb7dfb42464cad23aa9f1d536b55cfc1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle @airsquared Pushed as commit dfe764e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[airsquared]

This also resolved JDK-8306488, if someone can mark it as such.